> On Sept. 20, 2016, 5:33 p.m., Dan Smith wrote: > > I don't think having this special logic for slf4j-impl is necessary because > > slf4j-impl already marked optional. It was *not* optional in M3, because of > > GEODE-1811. So I think this bug was already fixed by GEODE-1811. > > > > As far as including/excluding test dependencies, I don't think it really > > matters since they have no effect. But maybe we should just stick with the > > default behavior of the gradle plugin?
Ok, makes sense. I'll drop this change. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52076/#review149687 ----------------------------------------------------------- On Sept. 20, 2016, 3:49 a.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52076/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 3:49 a.m.) > > > Review request for geode, Dick Cavender, Jens Deppe, Mark Bretl, and Dan > Smith. > > > Repository: geode > > > Description > ------- > > Remove test dependecies from pom as they are not needed for geode > applications. Also removes the log4j-slf4j-impl logging bridge. > This reduces the possibility for conflicts on the application > classpath. The bridge jar is still present on the server > classpath. > > > Diffs > ----- > > gradle/publish.gradle 8a579c2f166d42d980fec9bf01a2ecb2364ddacf > > Diff: https://reviews.apache.org/r/52076/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
