----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52229/#review150288 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On Sept. 24, 2016, 12:50 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52229/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2016, 12:50 a.m.) > > > Review request for geode, Anthony Baker and Hitesh Khamesra. > > > Repository: geode > > > Description > ------- > > Remving the spring-core usage in geode-core classes that are not cli or > web related. The CLI and web code needs to be split into separate > projects. The rest of the geode-core should not depend on spring-core. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java > 4bea22bcd57079849bc1ed96b8d7fc9ca8a7ab0c > geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java > bc1e896a2ed85260a9e9d95309735ea870d4761f > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/domain/XmlEntity.java > 47f032e594abf090d68f5bb4d4a41b4442244875 > geode-core/src/main/java/org/apache/geode/pdx/internal/PdxInstanceImpl.java > 10a11d267754531bcd5bf116fa598fc0b3d5aad1 > > Diff: https://reviews.apache.org/r/52229/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >