----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52269/#review150443 -----------------------------------------------------------
Ship it! Good change, this makes more sense than the stricter exception throwing we had written previously. - Jared Stewart On Sept. 26, 2016, 8:32 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52269/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 8:32 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1659: put security properties in the cluster config and applied to all > the members in the cluster. > > When joining a secured server, the server's security-manager and > security-post-processor should match whatever the cluster config is. > Also prevent a member not using cluster configuration from joining a secured > cluster. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/SharedConfiguration.java > 2e6677f3dff5bc9a811185e9844b22e4ed925971 > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 93a9c3b1686a82d8c7814fbda47650d4a26ebbd2 > > geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java > d341f51f493dc4e0391be26b15d64d7568c35fcb > > geode-core/src/main/java/org/apache/geode/management/internal/SystemManagementService.java > c42d1a259e21a02a4aee0dc3fd4c1a51779b79e3 > > geode-core/src/test/java/org/apache/geode/internal/cache/GemFireCacheImplTest.java > 597a977ccaab900fe38a4042b996daedaef99456 > > geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java > 8468664446a3953bf5dfb056621bfcbdd0c8daa4 > > Diff: https://reviews.apache.org/r/52269/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
