----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52323/#review150655 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On Sept. 27, 2016, 5:11 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52323/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2016, 5:11 p.m.) > > > Review request for geode, Bruce Schuchardt, Darrel Schneider, Jinmei Liao, > Jared Stewart, and Kevin Duling. > > > Bugs: GEODE-1945 > https://issues.apache.org/jira/browse/GEODE-1945 > > > Repository: geode > > > Description > ------- > > GEODE-1945: split and refactor JSSESocketJUnitTest > > The testing for ClientSocketFactory is extracted into the new test > ClientSocketFactoryIntegrationTest. Test has been updated to use > AssertJ and Rules. > > The testing for SocketCreatorFactory and SSL is extract into the > new test SSLSocketIntegrationTest. Test has been updated to be more > readable and to use AssertJ, Awaitility and Rules. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/net/ClientSocketFactoryIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/net/JSSESocketJUnitTest.java > e63a46f > > geode-core/src/test/java/org/apache/geode/internal/net/SSLSocketIntegrationTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52323/diff/ > > > Testing > ------- > > ClientSocketFactoryIntegrationTest > SSLSocketIntegrationTest > precheckin > > > Thanks, > > Kirk Lund > >
