----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52488/#review151207 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/management/internal/JettyHelper.java (line 72) <https://reviews.apache.org/r/52488/#comment219481> Eventhough it might be "good practice" to check for null,I don't think we should check for null. There will always be a SSLConfig object and we should expect one. We should rather fix the issue if the SSLConfig is not correctly configured. geode-core/src/main/java/org/apache/geode/management/internal/JettyHelper.java (line 198) <https://reviews.apache.org/r/52488/#comment219479> I don't think you should pass null. The SSLConfigurationFactory will always provide you with a SSLConfig object. This object might be a ssl-enabled=false, but that is ok. I think this should should be replaced with: SSLConfigurationFactory.setDistributionConfig(new DistributionConfig); final Server jetty = JettyHelper.initJetty(null, 8090, SSLConfigurationFactory.getSSLConfigForComponent(SecurableCommunicationChannel.WEB)); - Udo Kohlmeyer On Oct. 3, 2016, 5:52 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52488/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 5:52 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Kirk Lund, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > GEODE-420: fix Pulse test when not using any SSLConfig > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/JettyHelper.java > 089dbacb056da84d6d6ceb36dad6f09b9ce73890 > > geode-pulse/src/test/java/org/apache/geode/tools/pulse/testbed/driver/PulseUITest.java > a2365a2dfa3e221fa50664c3f8d96fae2bd93c86 > > geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java > 5024250f8ff3867e0f527d7ef5fbbd501e2d64ee > > Diff: https://reviews.apache.org/r/52488/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
