----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52759/#review152525 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/internal/cache/ha/BlockingHARegionQueueJUnitTest.java (line 190) <https://reviews.apache.org/r/52759/#comment221550> Remove these sleeps and use awaitility instead if necessary. geode-core/src/test/java/org/apache/geode/internal/cache/ha/BlockingHARegionQueueJUnitTest.java (line 192) <https://reviews.apache.org/r/52759/#comment221549> This should be 4 seconds geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARegionQueueJUnitTest.java (line 467) <https://reviews.apache.org/r/52759/#comment221552> This should be >=, not > - xiaojian zhou On Oct. 11, 2016, 11:52 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52759/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 11:52 p.m.) > > > Review request for geode, nabarun nag and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Getting rid of a bunch of sleeps in HARegionQueueJUnitTest to fix a > bunch of tests with race conditions. Tests of expiration were sleeping > for short amounts of time and then asserting that expiration happened or > didn't. Changing these sleeps to use Awailitily. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/BlockingHARegionQueueJUnitTest.java > 48fb3a2769994233ea7c899e324506c102517456 > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARegionQueueJUnitTest.java > 37047583d477c06ac9788ba5df960fe74b225229 > > Diff: https://reviews.apache.org/r/52759/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
