----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52931/#review152916 -----------------------------------------------------------
Ship it! geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java (line 47) <https://reviews.apache.org/r/52931/#comment222104> You could move these to the Rule and use a fluent style API: @Rule public LocatorServerStartupRule lsRule = LocatorServerStartupRule.builder().setProperty(SECURITY_PEER_AUTHENTICATOR, DummyAuthenticator.class.getName()).startLocatorVM(0).build(); JUnit started changing the base Rules to use fluent builder similar to the above. We have some Rules like this as well. - Kirk Lund On Oct. 17, 2016, 3:10 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52931/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2016, 3:10 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > * added more tetss > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java > 72dbd1aff32c718c1e6f72b940ade523c9cd8847 > > geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java > bb147c7a24868adf0aaa1e860ca6114ffa032afc > > geode-core/src/test/java/org/apache/geode/security/PeerSecurityWithEmbeddedLocatorDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java > 5364c910a4c4e9d24de8be26b63a62428f48d0a7 > > geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java > d3ed823887c15ca06aba76e20a964c25e5dee8b4 > > geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java > f6928bfa0db529c38b521d4bc72d013272981e1a > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > 71894c8a27a8768db2e7e99b1a2b981253e4ec67 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java > bcc5ab3bca842d741bced5c59117472c77659ba6 > > Diff: https://reviews.apache.org/r/52931/diff/ > > > Testing > ------- > > > Thanks, > > Jinmei Liao > >
