----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53108/#review153965 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On Oct. 26, 2016, 2:45 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53108/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 2:45 p.m.) > > > Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Kevin > Duling, Swapnil Bawaskar, and Dan Smith. > > > Bugs: GEODE-2012 > https://issues.apache.org/jira/browse/GEODE-2012 > > > Repository: geode > > > Description > ------- > > GEODE-2012: always write stat types to archive > > * alter NanoTimer and its use to make testing easier > * remove extra spaces in localized string > * import SuppressWarnings to make use of annotation cleaner > * new test for rolling stat files: FileSizeLimitIntegrationTest > * new test for rolling and deleting old stat files: > DiskSpaceLimitIntegrationTest > * new test to expose GEODE-2012 and confirm its fix: > StatTypesAreRolledOverRegressionTest > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/NanoTimer.java 12e91f8 > > geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java > 0e4fac2 > > geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java > 6d7b967 > > geode-core/src/main/java/org/apache/geode/internal/statistics/SampleCollector.java > 610e848 > > geode-core/src/main/java/org/apache/geode/internal/statistics/SimpleStatSampler.java > 7eaa1e0 > > geode-core/src/main/java/org/apache/geode/internal/util/concurrent/StoppableCountDownLatch.java > 740fd7f > > geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/statistics/FileSizeLimitIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/statistics/StatTypesAreRolledOverRegressionTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53108/diff/ > > > Testing > ------- > > precheckin passed everything! > > > Thanks, > > Kirk Lund > >
