----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53274/#review154301 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java (line 34) <https://reviews.apache.org/r/53274/#comment223789> I really, really recommend not using the Java primitive wrappers as trinary variables. A Boolean should be a true/false boolean as an object without this broken use of null. Boolean is by definition a binary. If you really have to have a tinary then please create a new enum or class: public enum Source { Locator, HTTP, RMI } Or whatever this is supposed to represent. The problem here is maintainability and clarity of purpose. I don't understand what you're doing or why without studying this code very closely. Everything should be very obvious and simple. GFSH and related code is already obfuscated well enough. - Kirk Lund On Oct. 28, 2016, 9:49 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53274/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2016, 9:49 p.m.) > > > Review request for geode, Kevin Duling and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1955: fix flaky tests by properly closing the gfsh instance in > ConnectToLocatorSSLDUnitTest > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java > 8426c6f52129472c9c0def172aeefd10f1491935 > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java > d3390ba6ce2990d05516b701f82d5f176e6f4d49 > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java > b2dc6fe334499456184e1d0cbc0297063d4c99ce > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > 25780e67dd3f7920e53162ef9400d2845e4c958b > > Diff: https://reviews.apache.org/r/53274/diff/ > > > Testing > ------- > > > Thanks, > > Jinmei Liao > >
