----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53345/#review154457 -----------------------------------------------------------
Fix it, then Ship it! geode-core/src/test/java/org/apache/geode/cache/query/dunit/PDXQueryTestBase.java (line 58) <https://reviews.apache.org/r/53345/#comment224022> What's this difference between PDXQueryTestBase and JUnit4PDXQueryTestBase? They both seem to be using junit4... geode-core/src/test/java/org/apache/geode/cache/query/dunit/PDXQueryTestBase.java (line 343) <https://reviews.apache.org/r/53345/#comment224023> Get rid of these log statements. - Dan Smith On Nov. 1, 2016, 6:22 p.m., nabarun nag wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53345/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 6:22 p.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Added new tests for PDX queries, order by queries and queries using indexes. > > * PDXInstance and PDXFactoryImpl were used to validate multiple class version > test rather than writing dummy PDX classes > * JUnit4CacheTestCase was used instead of Junit3 elements. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/HashIndexDUnitTest.java > 78b092f > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/JUnit4PDXQueryTestBase.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/OrderByPartitionedDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/PDXQueryTestBase.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxGroupByPartitionedQueryDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxLocalQueryDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxLocalQueryVersionedClassDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxQueryDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/PortfolioPdxVersion.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/PositionPdxVersion.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53345/diff/ > > > Testing > ------- > > Precheck-in passed > > > Thanks, > > nabarun nag > >
