Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/278#discussion_r86040503
  
    --- Diff: 
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
 ---
    @@ -1091,6 +1086,126 @@ public void testDestroyRegionWithSharedConfig() {
         });
       }
     
    +
    +  final String PR_STRING = " package com.cadrdunit;"
    --- End diff --
    
    You could add a real class to a sub-package of this test in the source tree 
and then copy that class out to the .jar file. I'm not sure why you'd be making 
this so complex other than to avoid checking in a .jar (which is a disallowed 
binary). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to