> On Nov. 2, 2016, 7:58 p.m., Jason Huynh wrote: > > Ship It!
Do you think a unit test should be written for this? Not sure how difficult or useful it would be... - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53399/#review154620 ----------------------------------------------------------- On Nov. 2, 2016, 7:29 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53399/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 7:29 p.m.) > > > Review request for geode, Jason Huynh and nabarun nag. > > > Repository: geode > > > Description > ------- > > I found this while working on GEODE-1985. AttributesDescriptor does a bunch > of string comparisons when it could do a single, more efficient instanceof. > > With a microbenchmark I found this sped up reevaluation of an entry when I > did an indexed query. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/query/internal/AttributeDescriptor.java > a11bea0752e8ed8184f0173f81be08b001cb6e19 > > Diff: https://reviews.apache.org/r/53399/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
