----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53402/#review154629 -----------------------------------------------------------
Ship it! Ship It! - Jinmei Liao On Nov. 2, 2016, 8:07 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53402/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 8:07 p.m.) > > > Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Jared > Stewart, and Kevin Duling. > > > Bugs: GEODE-2013 > https://issues.apache.org/jira/browse/GEODE-2013 > > > Repository: geode > > > Description > ------- > > GEODE-2013: throw IllegalStateException if resource type is missing > > The StatArchiveReader was throwing NullPointerException if it found a > Resource without a ResourceType. Now it throws IllegalStateException with a > message explaining that no ResourceType for the specified resourceTypeId > could be found. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java > ca1a6c49269a56600191ac7b0551670ffb0f2c82 > > geode-core/src/test/java/org/apache/geode/internal/statistics/StatArchiveWithMissingResourceTypeRegressionTest.java > PRE-CREATION > > geode-core/src/test/resources/org/apache/geode/internal/statistics/StatArchiveWithMissingResourceTypeRegressionTest.gfs > PRE-CREATION > > Diff: https://reviews.apache.org/r/53402/diff/ > > > Testing > ------- > > StatArchiveWithMissingResourceTypeRegressionTest > precheckin > > > Thanks, > > Kirk Lund > >
