> On Nov. 7, 2016, 6:11 p.m., Darrel Schneider wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java,
> >  line 4013
> > <https://reviews.apache.org/r/53503/diff/1/?file=1554931#file1554931line4013>
> >
> >     I see other places in the code that handle RegionDestroyedException by 
> > throwing a TransactionDataNotColocatedException.
> >     This code does that for BucketNotFoundException.
> >     Why did you chose on a RegionDestroyedException to throw 
> > TransactionDataRebalancedException instead of 
> > TransactionDataNotColocatedException?

Only when bucket is moved, we will see ForceReattemptException with the cause 
set to RegionDestroyedException. Throw TransactionDataRebalancedException is 
correct when bucket is moved to a different node.


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53503/#review155168
-----------------------------------------------------------


On Nov. 4, 2016, 10:57 p.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53503/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 10:57 p.m.)
> 
> 
> Review request for geode, anilkumar gingade and Darrel Schneider.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Throws TransactionDataRebalancedException when get call on a key in a bucket 
> that has been moved.
> 
> 
> Diffs
> -----
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
>  8f67e25 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/TXStateProxyImpl.java
>  a89cdc4 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java
>  bedb1d4 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java
>  37ea4e5 
> 
> Diff: https://reviews.apache.org/r/53503/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Reply via email to