----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53557/#review155241 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java (line 3273) <https://reviews.apache.org/r/53557/#comment225108> If pdx.getClassName() is not equals to JSON_CLASSNAME then would it make sense to set valueClassName to pdx.getClassName()? That way you could have "read-serialized" set to true and still have a meaningful value constraint with pdx geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java (line 3281) <https://reviews.apache.org/r/53557/#comment225110> Is ".equals" too specific? You want something like instanceof. For example if the value-constraint was "Number" you would want it to be satisfied if "valueClassName" was "Integer", "Long", etc. You could do this with Class.isAssignableFrom(this.valueConstraint) but in that case you need to load a class for "valueClassName". One of the goals of pdx is that you do not need to be able to load the domain classes on the server, so you might not want to do this check. If you leave it with just a simple equals check you should document that in the case of pdx the value-constraint needs to exactly match (i.e. no instanceof support). - Darrel Schneider On Nov. 7, 2016, 2:13 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53557/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 2:13 p.m.) > > > Review request for geode, Barry Oglesby, Hitesh Khamesra, and Udo Kohlmeyer. > > > Bugs: GEODE-2080 > https://issues.apache.org/jira/browse/GEODE-2080 > > > Repository: geode > > > Description > ------- > > If you set a value constraint on a cache Region you will be unable to store > objects in the region via the Rest API. This change-set modifies > LocalRegion's constraint check to look for a Rest document and use its type > name in the constraint check > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > 3873e6e159ebba4c1a288e9fccde5dbabd2a1140 > geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java > 9a9680a7e14ddec91f005fa0f0c6c3da8d033df2 > > Diff: https://reviews.apache.org/r/53557/diff/ > > > Testing > ------- > > new test, precheckin > > > Thanks, > > Bruce Schuchardt > >
