----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53596/#review155455 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java <https://reviews.apache.org/r/53596/#comment225432> This is verifying java version when cache is getting created and warns the user if its not compatible version...I think we should keep this instead of removing it... - anilkumar gingade On Nov. 9, 2016, 5:08 a.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53596/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 5:08 a.m.) > > > Review request for geode, Jacob Barrett and Kirk Lund. > > > Repository: geode > > > Description > ------- > > The logic for evaluating jdk versions is incorrect for 3-digit builds. > Since we require a jdk1.8 version anyway, remove the check. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > e1b2007c12804d3fb668ef42e976b8f5a1bcb3d5 > > geode-core/src/main/java/org/apache/geode/internal/cache/MinimumSystemRequirements.java > a2c1874d9b37ee0268a6848a4c4ca98dc92cc16f > > geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java > fbe18d048bfce2bb1ce7fb30962f97bec52b5091 > > Diff: https://reviews.apache.org/r/53596/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
