> On Nov. 9, 2016, 3:40 p.m., Anthony Baker wrote: > > Do we want to check in generated code? Should we hook this into the build > > script?
I filed GEODE-2093 for this issue - Darrel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53632/#review155516 ----------------------------------------------------------- On Nov. 9, 2016, 5:01 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53632/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 5:01 p.m.) > > > Review request for geode, Eric Shu and Ken Howe. > > > Bugs: GEODE-1785 > https://issues.apache.org/jira/browse/GEODE-1785 > > > Repository: geode > > > Description > ------- > > The main addition here is the shell script "generateRegionEntryClasses.sh" > and the cpp file "LeafRegionEntry.cpp". > The old generated files had a comment that tells you how to regenerate it and > this comment was not wrong. > So all the changes to the java files in this review should just be to that > comment. > > I basically modified LeafRegionEntry.cpp until the source files it generated > (after running gradle spotlessApply) > where exactly the same as what was already checked in. Then I changed the > comment to have corrected instructions > on how to generate these files. > I tried to change LeafRegionEntry.cpp to generate files that where already > correctly formatted but this was > not possible because of the odd line breaks that cpp conditionals would add. > So the new instructions are to run generateRegionEntryClasses.sh followed by > 'gradle spotlessApply'. > > > Diffs > ----- > > dev-tools/generateRegionEntryClasses.sh PRE-CREATION > > geode-core/src/main/java/org/apache/geode/internal/cache/LeafRegionEntry.cpp > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryHeapIntKey.java > 41bd3346c7a275b5fe83fe1df35ac87cc611dd83 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryHeapLongKey.java > 1ae6628a6643a0fb74e4f7d91ccef75f28fd18d4 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryHeapObjectKey.java > e046d65148b4b5239d7e43d79366499265f06bdc > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryHeapStringKey1.java > 57cab2d4d690638e968f889494fb74c4d9b7a2c6 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryHeapStringKey2.java > 6f0665359c22fe19acf67f5312b21b5ff785f08e > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryHeapUUIDKey.java > 1dd442844ddc6235e1ea1bb67185d5740202e188 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryOffHeapIntKey.java > 421477de5194a3f477e1f3e3ba900ff6ac774ed3 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryOffHeapLongKey.java > 76bf1e257366c53eb8444bd3f61b056c685b7d77 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryOffHeapObjectKey.java > a6186a5bea3457c029fbbcec5238bd805dd150bc > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryOffHeapStringKey1.java > eac0af5419b9fa540133879ff8ae671e601412ad > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryOffHeapStringKey2.java > bba9ef31402fae2574acc2788f0a3d9143c44eea > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskLRURegionEntryOffHeapUUIDKey.java > 5ab2d0bf8cfd390b622b77b2bb14c475b7e927da > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryHeapIntKey.java > d50319a770d5d5c312473f438183d0b9224f0e2a > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryHeapLongKey.java > de829cbf9686d50f60822f61b80a38373bac20cc > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryHeapObjectKey.java > b73bb52de991fee6099b4b16d36ca64f5a07da39 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryHeapStringKey1.java > 33ece05e69a6be44106a0891d11f1e57b4a5c156 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryHeapStringKey2.java > 894ac5554a0ddb80e90c7218592af2405087e833 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryHeapUUIDKey.java > a28373395b919bfeeb124a7832430b5b985663f7 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryOffHeapIntKey.java > f45f772bc82a865ef95a14adae4b453a81b9bf7d > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryOffHeapLongKey.java > c58859549d921359762c281fd2917eb975cca72a > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryOffHeapObjectKey.java > b66d160437ca486ccae7dcd3ee0d09b83ebc060d > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryOffHeapStringKey1.java > 92cef483e06f1d0638c5761efec2ce05e1f86f19 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryOffHeapStringKey2.java > c9a990480586d36bc9ac22fcb7f3d2fab429c336 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsDiskRegionEntryOffHeapUUIDKey.java > 2e8f033220da0bf8e3daf23d21dab16f0d1c13be > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryHeapIntKey.java > 66b34d621c306739baef65808fac209e3adf6d92 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryHeapLongKey.java > 442736ee727df04598ff14b515f02296532b6f38 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryHeapObjectKey.java > d12066ac462e2ad8d493b93ae2e5b1ad982a6c2c > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryHeapStringKey1.java > 1de7a210ea546ada92ad79712b90c50bee6d88f9 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryHeapStringKey2.java > e1b58eb716bb90a7e400da362b46a88c407ab0bc > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryHeapUUIDKey.java > a5c327bfedb9b330068a4da4ca77afba43763555 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryOffHeapIntKey.java > 2d39ac5c750c2c1b2f7696ec5f2fb94ae4b99317 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryOffHeapLongKey.java > 0ffaddf3e66edcbd7751a54ee5dcf0f11e9988e8 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryOffHeapObjectKey.java > f990481cb569107d6da065650ee71e06c6b275fa > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryOffHeapStringKey1.java > 2e55620fe7eaaae8a4b90de2744ce0489186b1a8 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryOffHeapStringKey2.java > 6a7c0ae2db54a6dca09217c15c70d2e07c7ba393 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsLRURegionEntryOffHeapUUIDKey.java > 7d1c8c7faa328b796e06faa53afb0a44c4f4cc02 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryHeapIntKey.java > a77b0fbc0e330b0a28717de77ff0164330c8c232 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryHeapLongKey.java > 51944a48fe17a4ef8639e1d32c86aee5c972b36b > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryHeapObjectKey.java > 9aaca74e48cd3129c58de983d04b7675ed13e7e3 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryHeapStringKey1.java > d5fb7c39e0a7f2eca4db7522eff38edf674c3f5c > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryHeapStringKey2.java > e4a5c6a66448517d03697d8bf9fe299d84013ec4 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryHeapUUIDKey.java > 6e7bded0a33adaf81300aa703d7b34c873e016cf > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryOffHeapIntKey.java > bb209f13d8fd9f4d926e3a60b0581e0de8bbb928 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryOffHeapLongKey.java > e2928543cb00e91b58a844ed40122051d43ef568 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryOffHeapObjectKey.java > 8af273b621a154d750358a30be762ae192486f68 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryOffHeapStringKey1.java > 38e4e17d7bd2e0b7bb55279be7e7e819672d2263 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryOffHeapStringKey2.java > 969b8dc72852201e57388511d4b3d4888ac1a197 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMStatsRegionEntryOffHeapUUIDKey.java > 9b12b4a4c1a2f66cc68fe59cc499ecda605ad9f2 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryHeapIntKey.java > dc31295f3f0f6b2c7328e3b919136b6c276b0994 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryHeapLongKey.java > 8733cb38a303f50eb2f5c0111e1d3f60f2a48cf7 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryHeapObjectKey.java > 1d177e3749abb1d850d2b8d323d0d695d97369fc > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryHeapStringKey1.java > 8de3f2c4b5d4df45a02979a6eef0008d130e0ec2 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryHeapStringKey2.java > d682214782de3a5e9c8db62d0304bd5401b77d29 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryHeapUUIDKey.java > 68e0c17be1aab9f11a09cb61ff66d448f44292cd > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryOffHeapIntKey.java > 500ef2a96b5926c163857a0de46cdb1f1467e932 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryOffHeapLongKey.java > b8fd1230589b3e53169533e892341be25c219953 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryOffHeapObjectKey.java > ca869ec1d5d55bcb2cc615d621aa9c9bd3f9b604 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryOffHeapStringKey1.java > 44f4b6fd485d5b5471c04a457108ba102c0cfc94 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryOffHeapStringKey2.java > 13a94b496d062452d830eab464238b4fd211fd7b > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskLRURegionEntryOffHeapUUIDKey.java > 5924846a26925804f438d19f5918471b9886bceb > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryHeapIntKey.java > 6d0555ae82a7b59e1adcdc4f5723c6befc06df69 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryHeapLongKey.java > 8914996e90d5a8b4782d2cab78d07bc79d1f46aa > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryHeapObjectKey.java > e428c32324a43b42beaf28fa0085d6dc1c2f451d > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryHeapStringKey1.java > 853fd2ec5327933f5433299eadc67cab6e88c83d > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryHeapStringKey2.java > f0413ecfd2ae949a3612461b6d8ab1e5be81c462 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryHeapUUIDKey.java > 73ba9d6448bdaa9c969f9669a37041f65545b30d > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryOffHeapIntKey.java > d786dab00783b86f2fb47d82a28f1baddbded3bf > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryOffHeapLongKey.java > a67f37b2b271aee3db63de8c0b7e4dc5a6a64a97 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryOffHeapObjectKey.java > 57a8fb971481ed7f080b2e612e266730f318cb32 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryOffHeapStringKey1.java > c8baec2c3571e2461058a46096d5974b0a0ab9e1 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryOffHeapStringKey2.java > 4fece657d1e3c4399ba15e2991911ffff81b0ca4 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinDiskRegionEntryOffHeapUUIDKey.java > 5f1a27a912555cb3c69190669f7d990866ec7dd8 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryHeapIntKey.java > 84d23f7de8f62353efb002ba259f6ed2703f75d9 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryHeapLongKey.java > c43cc44fd5181e63397e18005854c02f9421f9f6 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryHeapObjectKey.java > c6fcf2080d4a0dba9e31c07842efa59d732c3345 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryHeapStringKey1.java > 3dfd8c9390bf4e54de244c53ebab89afdf1f3ff6 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryHeapStringKey2.java > 670c78b263f9b1f03856c1bb4ccd2b523814ea6e > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryHeapUUIDKey.java > 90c635ad6a5057b57418f11fc5689cf8fd86cac5 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryOffHeapIntKey.java > cd9b38dd6a3a73e905901811da143015b36553db > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryOffHeapLongKey.java > 0e3e7667524fc6d79809653bc350b379479379ee > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryOffHeapObjectKey.java > bcad9632fc00f8f41fe5e716c25bb1d2cb418bdb > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryOffHeapStringKey1.java > dca37151037ae00c9d000c141fb989f711b65bae > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryOffHeapStringKey2.java > 9edb25a41957fffa8c7ecc8840b370e53b673618 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinLRURegionEntryOffHeapUUIDKey.java > 9121804aab0db56dcf86ec9a7d457ef4d3f3e796 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryHeapIntKey.java > b66850e2eb85033abbd22a7d910312f47d6271c0 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryHeapLongKey.java > 1c59cc62f276e861d4bf6247b59ca596d26ae068 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryHeapObjectKey.java > b05179a81251e2ba44117fb015f092ad90d04d2c > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryHeapStringKey1.java > 3faa44d73717746c5c6772d204d14bcb3bbef28d > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryHeapStringKey2.java > 8a523adb3336143390ca902c16ed125f0aebabd3 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryHeapUUIDKey.java > 8b215238b2681a8d4db36e48e17e86def4976227 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryOffHeapIntKey.java > ecb49714927a8233827c347441b1c13e9444fadc > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryOffHeapLongKey.java > e4bbbba90aaa6783d9087811d077604c1347344a > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryOffHeapObjectKey.java > 95c8dc1e27e612df1d1becfcccd484ae92aa18e7 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryOffHeapStringKey1.java > f23fb6f089f3ab4f4b4a595042fd37cd5637f050 > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryOffHeapStringKey2.java > 7f688a30e3aefa578beb0c401f6148cabf9e525f > > geode-core/src/main/java/org/apache/geode/internal/cache/VMThinRegionEntryOffHeapUUIDKey.java > d18456ae230a9e4916e4e7b022c8071bb31f0f42 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryHeapIntKey.java > cfce45813c6da8a3e904f3dc140c370e10b4e68b > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryHeapLongKey.java > 138db428089498c98bf4fba77d440211abfc3b6a > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryHeapObjectKey.java > ec89e1e79ab84973167b800e13e82eabd6522f24 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryHeapStringKey1.java > 828f2da460de32b63ebbf01e0b14631ae2d7eca7 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryHeapStringKey2.java > 8e55f609da928f66904bd2a389f14dd178e900bf > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryHeapUUIDKey.java > 42c841eee3a223b2864dea810df3155a96517fbe > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryOffHeapIntKey.java > 3773fc7ce79ccd0ba69d6833c38d0b434d2480a1 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryOffHeapLongKey.java > 85194c99e3dd44025e54b5325ede4a06a070c532 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryOffHeapObjectKey.java > 6814f8d0d0255b71a631488c25b8093f0ec1809d > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryOffHeapStringKey1.java > 4b4bfde487733a91863e695dec8a2206b77018f7 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryOffHeapStringKey2.java > 590004183f481fe623946efa871b532352edf6ac > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskLRURegionEntryOffHeapUUIDKey.java > 125cf69064524afdac3d8032cc0d32ecb993c4aa > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryHeapIntKey.java > da721a7ba1fcc7716ce6d5742e1e22ca85ae8d47 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryHeapLongKey.java > b9178bb3f8410050503fe20c27d22c87fbd8e5c5 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryHeapObjectKey.java > fbe2816940f81632233829ad427524f2ce8a4e4d > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryHeapStringKey1.java > 9d2c8bc43ad10d5dea6dd27aa8969a58ccb7956c > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryHeapStringKey2.java > c3af973ac00c71d7465e92086603b45b7e2c3914 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryHeapUUIDKey.java > 6b235ec37222d9e226a8206ec478c65ace0212ff > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryOffHeapIntKey.java > 11d854b83a0bc4b253b20270cea90931ec972ed4 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryOffHeapLongKey.java > 6b3816e88c473ecbc31ad8de4289369dafb2b1ba > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryOffHeapObjectKey.java > 40c8e4c5ef387225bb104ba8f85720f775a94ae1 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryOffHeapStringKey1.java > 335dff808b35aa116bbd309535a1c0433250c3ab > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryOffHeapStringKey2.java > 7b20bf27a804bc2fda0aebdef010bec4f18d1b3e > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsDiskRegionEntryOffHeapUUIDKey.java > 2ab64018e0e825e9bd20c5a5e7ea68fa8a071dd2 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryHeapIntKey.java > e00966b182dcb5d1782c63d7fe4e43d89468fe4f > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryHeapLongKey.java > 5c5c8c581cc03207cc4c16a234db727d75a85393 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryHeapObjectKey.java > 59b9fe44816e587fd2043747d36c709fa25149bb > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryHeapStringKey1.java > c13af731c32626b97390e6b1ba010e1b728b98bc > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryHeapStringKey2.java > 2c7ce6ac0c594e865ffa19c0756e981253409d4a > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryHeapUUIDKey.java > 02571a99b08eebe35d4f9348c2df09ec045a3e44 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryOffHeapIntKey.java > 98a70a0319942830df1c4088cffc8501b92d870b > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryOffHeapLongKey.java > 5677dc68fb813173895ebf90b47adb17af974317 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryOffHeapObjectKey.java > c4ac5041a9c737214ead59b78d29fe451523fa22 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryOffHeapStringKey1.java > 020df97e1e9f44403c520d8198509679ca09b628 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryOffHeapStringKey2.java > 080564892369e04b9d5a1850f45c4fe1ad526308 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsLRURegionEntryOffHeapUUIDKey.java > d0d6b0b9ce6e150d89b11da6ef3840f4e605f70d > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryHeapIntKey.java > 55acb7902c350f2f42c03cc72ca1ba612c12fb9a > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryHeapLongKey.java > b7d90f36f5df432cb0873d790d75891b36ef7102 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryHeapObjectKey.java > 4047e7008dc6db999b3417c5313a9fb379886224 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryHeapStringKey1.java > b0d7e294071e8261a07c3ea0245c46bcf1e0ab85 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryHeapStringKey2.java > 1225b5506a73f8fb43e500b0af62eeec5ce5b825 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryHeapUUIDKey.java > 56663e8e7f4f9d644114b63388b4298e1d90c1e2 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryOffHeapIntKey.java > a9b21686d8a70fd99d2f9e5d7a51532aa2298cc0 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryOffHeapLongKey.java > 7bf5fb6731e3d80545d2be4d9500198e6df5c5c8 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryOffHeapObjectKey.java > 6be3ee96c9e32fdbed5c2014c4c5b6b8b1b8cac3 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryOffHeapStringKey1.java > a158f7500b219463dadc71400be4427b2dc459fc > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryOffHeapStringKey2.java > 8f7eb324fc249adbbefe8f145ee9bacbcafb5277 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedStatsRegionEntryOffHeapUUIDKey.java > 7cc0e3a9d8522202f7e76655ae3445d88c4dbe81 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryHeapIntKey.java > 3d5ec140c32550ffd26bc1971575ab66a78d58bd > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryHeapLongKey.java > 27eccc78ae307cf4db93ae5da839997308f660cf > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryHeapObjectKey.java > c427ffd5831a0dc58afc006ae16734f3b06e0a0e > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryHeapStringKey1.java > 3305b987c53b2ee0c471d9646b194af714dff864 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryHeapStringKey2.java > e02c51bef22ad99d3b513560c73a6504ac78d27e > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryHeapUUIDKey.java > 0818dbc608c62ac828e66bc795d25a71894427cd > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryOffHeapIntKey.java > 0705e71b930bea63f3f11e9c3494a82ef260e609 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryOffHeapLongKey.java > 3f059cadaf9d5d3e745a62c517352af19f6f7fa6 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryOffHeapObjectKey.java > b1dfc09069c3e60b59b17f52f40430a5d3737033 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryOffHeapStringKey1.java > 69fdb695b2a580f2fefe50bc93b513f085631f6d > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryOffHeapStringKey2.java > 2d3382dbd451b4a2a2f2a99dd32898062aa24a30 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskLRURegionEntryOffHeapUUIDKey.java > d21ffce3490ad6b87d9da0db6a8c6074c579504a > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryHeapIntKey.java > 962c402eff267ca2f2b2a8460412ab582ff36e39 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryHeapLongKey.java > a759b93b3a7183b590b229507af969c430434bab > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryHeapObjectKey.java > 4fda44ce72ad4f01d22163360e296001f920a13f > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryHeapStringKey1.java > c16f23bb2c4a9bb58936dbebec83816e275c2e92 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryHeapStringKey2.java > 75686361d91670e5dc6c83bba6fbf8150c4d77bb > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryHeapUUIDKey.java > bef8158eaa2b7d520bb41cef25a8a01dbd731840 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryOffHeapIntKey.java > 99587ad0b01e3cc552b1e29dbe2e197ff40ab900 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryOffHeapLongKey.java > 8214cc71fa2be891bde47824f355b77a19154f48 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryOffHeapObjectKey.java > aa8c9f235a4ba4b7ba1a6580b5841a9574116245 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryOffHeapStringKey1.java > 804f7bcd862e88585c2c35a077b5f7ebe71ff5f2 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryOffHeapStringKey2.java > a385962eca9586f50f183c0b43c38257c1f1cc03 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinDiskRegionEntryOffHeapUUIDKey.java > 3c1d08836c0b9b1bad1b583204c9ba43cf6ec133 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryHeapIntKey.java > 0ba441d599220937df6818d139d364c3c731e0f8 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryHeapLongKey.java > c5237837cedc87bdf215c15e2d17d168fbb88edf > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryHeapObjectKey.java > a53adeb5678d0f9df349f25210c07bce6923b685 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryHeapStringKey1.java > 44c7ef7e71aab9c1f8d0ecaff94501d3e3c2d4ee > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryHeapStringKey2.java > 91ecc63ab64b81b76f9ff3cb7c1189e72d4ab1b1 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryHeapUUIDKey.java > 4ace7b0bf6569a04ac3ebbf80f441722d6514fc9 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryOffHeapIntKey.java > ae00c226c2877ea0769a848b6ea5140affc82262 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryOffHeapLongKey.java > 6eb8ad29e084edc040f3eae2dde79b6e505ff84c > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryOffHeapObjectKey.java > f55965eb84aa5d537a266a76a7700912b72cfe15 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryOffHeapStringKey1.java > 3dbc946d2d1bffd881cb57a45019cb0636c69c3f > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryOffHeapStringKey2.java > 162e103967b1723d4276e5fc99c9881f119aefb4 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinLRURegionEntryOffHeapUUIDKey.java > 24fb7f511371c80b500dee58cb1a3b72a4a4c277 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryHeapIntKey.java > 733907070320ad173961aee082637109d15c4dc0 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryHeapLongKey.java > 0078d884b261c51164814eadaa00578ba0c75f24 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryHeapObjectKey.java > dc4b28d513681580f7a3a512c7ece771202221b2 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryHeapStringKey1.java > 44d2ab4e63d71fe9a64385daa2133d5261aa045f > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryHeapStringKey2.java > 220515f84f7d0d8f9d3fefc0f0288692a90b905a > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryHeapUUIDKey.java > a3472119551d6e4c535df989d4cae95df55621ac > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryOffHeapIntKey.java > 89747adfdbcc97c16e762ccc08871b7596afe7a8 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryOffHeapLongKey.java > f1059d1b6243105bce090d52500f442bc6e557e8 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryOffHeapObjectKey.java > 11e81663ada25bd73bc44da90051a2239241e054 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryOffHeapStringKey1.java > 1f133ec0ee0d9ca226f67f239767ad6058b2b372 > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryOffHeapStringKey2.java > 9e616380cd0082d0a72a9ea1887b35dcd27c787f > > geode-core/src/main/java/org/apache/geode/internal/cache/VersionedThinRegionEntryOffHeapUUIDKey.java > 5cb31ce1e67403f1b62ab06ec2499ad926ccb2bc > > Diff: https://reviews.apache.org/r/53632/diff/ > > > Testing > ------- > > precheckin, spotlessCheck > > > Thanks, > > Darrel Schneider > >
