-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53736/#review155860
-----------------------------------------------------------


Ship it!




Ship It!

- Darrel Schneider


On Nov. 14, 2016, 10:13 a.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53736/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2016, 10:13 a.m.)
> 
> 
> Review request for geode, anilkumar gingade and Darrel Schneider.
> 
> 
> Bugs: GEODE-2088
>     https://issues.apache.org/jira/browse/GEODE-2088
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Turns out the transaction layer code has already handled when to throw 
> TransactionDataNotColocatedException in getTransactionException method call 
> in TXStateProxyImpl by checking whether the key is colocated with the keys 
> already touched in the transaction. Only need to make sure that piece of code 
> will be executed by throwing correct TransactionException.
> 
> 
> Diffs
> -----
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
>  96c58d5 
>   geode-core/src/test/java/org/apache/geode/disttx/PRDistTXDUnitTest.java 
> ed8d3c6 
>   
> geode-core/src/test/java/org/apache/geode/disttx/PRDistTXWithVersionsDUnitTest.java
>  4e6f846 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java
>  e2ba2b3 
> 
> Diff: https://reviews.apache.org/r/53736/diff/
> 
> 
> Testing
> -------
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

Reply via email to