> On Nov. 15, 2016, 4:43 p.m., Kevin Duling wrote: > > Why would we move away from using Jackson in favor of our own JSON mapping > > code? Or is this a special case where we do some magic serialization we > > can't do via Jackson?
I tried using Jackson's converter, but it's giving errors about no default constructor on one of the object it's trying to convert to. Apparently, Jackson's converter requires the object either have some annotation or a no-param constructor in order for it to work, but our own doesn't. - Jinmei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53784/#review155927 ----------------------------------------------------------- On Nov. 15, 2016, 3:06 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53784/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 3:06 p.m.) > > > Review request for geode, Jens Deppe, John Blum, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1247: unable to stop server using http connection > > I believe after we added the "com.fasterxml.jackson.databind.ObjectMapper" > into core, the a mapper is added to the RestTemplate to precedes our own > message converter (SerializableObjectHttpMessageConverter), so on the client > side, we are using Jackson's converter to convert the message, but on the > server side, we are using our own converter, this caused the message corrupt > error. Fix is to remove the Jackson's converter from the client side. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/util/IOUtils.java > 4c1cc5f79a3bed922347835441f6624931bdcc6b > > geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java > 25eee8295ac553da416eb928b160fe7897b17763 > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/QueryNamesOverHttpDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53784/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
