On Fri, Jul 1, 2011 at 4:35 PM, Matt Priour <[email protected]> wrote: > So you want to use my plug-in patch instead of your non-documented api > 'auto-magic' patch?
Yes. Let's use plugins wherever possible. > I can modify the plug-in to ensure that the TreeNodeUIEventMixin is only > added when it is needed and not added to nodes already containing the mixin. I think the plugin should never change the UI of a node. So the events should only be registered when an appropriate UI is in place already. > The sequence for determining uiClass is taken directly from ExtJS source and > is the same sequence it uses for tree nodes. Cool, then let's stick with that. > Would that be enough to get that plug-in into trunk? I would like to make sure that it also works with LayerParamNode nodes, and an example (at least a code snippet in the docs) showing how to do this. Other than that, I would be happy to do a final review if you make these changes. Thanks, Andreas. > > Matt Priour > Kestrel Computer Consulting > From: Andreas Hocevar > Sent: Friday, July 01, 2011 8:05 AM > To: Alexandre Dube > Cc: GeoEXT Dev > Subject: Re: [Dev] Ticket 235 > Hi Alexandre, > > if you could take Matt's latest patch and address the concerns raised > in my review, this would help a great deal. > > Thanks, > Andreas. > > On Thu, Jun 30, 2011 at 8:32 PM, Alexandre Dube <[email protected]> wrote: >> Hello, >> >> I'm just wondering if there are plans to commit the latest patch >> attached to ticket 235 : http://trac.geoext.org/ticket/235 I would be >> willing to give any help I could to push it forward. >> >> Thanks, >> >> -- >> Alexandre Dubé >> Mapgears >> www.mapgears.com >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://www.geoext.org/cgi-bin/mailman/listinfo/dev >> > > > > -- > Andreas Hocevar > OpenGeo - http://opengeo.org/ > Expert service straight from the developers. > _______________________________________________ > Dev mailing list > [email protected] > http://www.geoext.org/cgi-bin/mailman/listinfo/dev > > _______________________________________________ > Dev mailing list > [email protected] > http://www.geoext.org/cgi-bin/mailman/listinfo/dev > > -- Andreas Hocevar OpenGeo - http://opengeo.org/ Expert service straight from the developers. _______________________________________________ Dev mailing list [email protected] http://www.geoext.org/cgi-bin/mailman/listinfo/dev
