[ http://issues.apache.org/jira/browse/GERONIMO-846?page=all ]
Joe Bohn updated GERONIMO-846:
------------------------------
Attachment: logSettings.patch
Updated patch to account for Web Console moving from sandbox to main
> Log Level set on Console is overridden by serverlog properties setting even
> if the properties setting hasn't changed.
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-846
> URL: http://issues.apache.org/jira/browse/GERONIMO-846
> Project: Geronimo
> Type: Bug
> Components: management, common
> Versions: 1.0-M4
> Environment: Windows XP
> Reporter: Joe Bohn
> Attachments: logSettings.diff, logSettings.patch
>
> Each update action from the LogManagerPortlet invokes the appropriate 3
> methods on the SystemLog without checking for actual changes in the submitted
> values. For the refresh interval this isn't a problem because Log4JService
> checks itself to ensure the period has changed before updating the value.
> For the logging level this also isn't a problem because there is no ill
> effect to updating the level with the exact same level. However, when
> setting the ConfigFileName the Log4JService doesn't check the value and
> assumes that there really is a new file and therefore sets the lastChanged
> value to -1 to ensure that the file values will take effect on the next timer
> refresh. The result is that any change (including only a change to the
> logging level) from the console also guarantees that the file settings will
> be refreshed.
> I propose the following:
> 1) Change the LogManagerPortlet to ensure that the name or level has changed
> before updating the SystemLog (Log4JService) ... I'd also ensure that we
> check for changes in the refresh period as well just for good measure. This
> way we won't was time setting things that haven't changed.
> 2) Change the Log4JService to always check for an actual change to the level
> and/or the configPathName before taking any real action (just as it does for
> refresh interval today). This will clean things up so that another object
> invoking this service unnecessarily doesn't create a similar problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
