Well, you're free to wait for more input, that's just my 2 cents... :)
Aaron On Wed, 24 Aug 2005, Jeff Genender wrote: > No problem...I'll fix it in a jiffy. > > Aaron Mulder wrote: > > I would prefer present/not present to true/false/missing. I don't > > think it's clear what missing means -- as far as an end user is concerned > > the default could go either way, so it just adds to our documentation > > requirements. > > > > Aaron > > > > On Wed, 24 Aug 2005, Jeff Genender wrote: > > > >>6 of one / half-dozen of the other. I am just following the same > >>paradigm as the initParams (and how Tomcat attributes work). Missing is > >>the same as false. If there are strong feelings of doing it the other > >>way, I am more than happy to back out the xsd. I just wanted things to > >>be consistent. > >> > >>Would you prefer that I back it out? I have no strong feelings either way. > >> > >>Jeff > >> > >>David Jencks wrote: > >> > >>>Out of curiousity, why do you think explicit true/false is better than > >>>missing == false, <cross-context/> == true? My thinking in using the > >>>latter was that it is unambiguous, whereas with an optional true/false > >>>value, what does missing mean? This is not a big deal, I just wonder > >>>what your reasoning is. > >>> > >>>thanks > >>>david jencks > >>> > >>>On Aug 23, 2005, at 9:42 PM, [EMAIL PROTECTED] wrote: > >>> > >>> > >>>>Author: jgenender > >>>>Date: Tue Aug 23 21:42:17 2005 > >>>>New Revision: 239527 > >>>> > >>>>URL: http://svn.apache.org/viewcvs?rev=239527&view=rev > >>>>Log: > >>>>Updates the xsd for true false and added in the eclipse stuff > >>>> > >>>>Modified: > >>>> geronimo/trunk/modules/tomcat-builder/project.properties > >>>> geronimo/trunk/modules/tomcat-builder/src/schema/geronimo-tomcat.xsd > >>>> > >>>>Modified: geronimo/trunk/modules/tomcat-builder/project.properties > >>>>URL: > >>>>http://svn.apache.org/viewcvs/geronimo/trunk/modules/tomcat-builder/ > >>>>project.properties?rev=239527&r1=239526&r2=239527&view=diff > >>>>======================================================================= > >>>>======= > >>>>--- geronimo/trunk/modules/tomcat-builder/project.properties (original) > >>>>+++ geronimo/trunk/modules/tomcat-builder/project.properties Tue Aug > >>>>23 21:42:17 2005 > >>>>@@ -5,4 +5,7 @@ > >>>> maven.junit.jvmargs=-Djava.security.auth.login.config=src/test- > >>>>resources/data/login.config -ea > >>>> maven.junit.fork=true > >>>> > >>>>+# Include the generated xmlbean classes in the eclipse classpath > >>>>+maven.eclipse.classpath.include=${basedir}/target/ > >>>>xmlbeans,${basedir}/target/xmlbeans-classes > >>>>+ > >>>> maven.idea.generated.source=xmlbeans > >>>> > >>>>Modified: > >>>>geronimo/trunk/modules/tomcat-builder/src/schema/geronimo-tomcat.xsd > >>>>URL: > >>>>http://svn.apache.org/viewcvs/geronimo/trunk/modules/tomcat-builder/ > >>>>src/schema/geronimo-tomcat.xsd? rev=239527&r1=239526&r2=239527&view=diff > >>>>======================================================================= > >>>>======= > >>>>--- > >>>>geronimo/trunk/modules/tomcat-builder/src/schema/geronimo-tomcat.xsd > >>>>(original) > >>>>+++ > >>>>geronimo/trunk/modules/tomcat-builder/src/schema/geronimo-tomcat.xsd > >>>>Tue Aug 23 21:42:17 2005 > >>>>@@ -29,12 +29,17 @@ > >>>> <xs:complexType name="tomcat-configType"> > >>>> <xs:sequence> > >>>> <xs:element name="host" type="xs:string" minOccurs="0"/> > >>>>- <xs:element name="cross-context" type="tomcat:emptyType" > >>>>minOccurs="0"/> > >>>>+ <xs:element name="cross-context" > >>>>type="tomcat:trueFalseType" minOccurs="0"/> > >>>> <xs:element name="valve-chain" type="xs:string" > >>>>minOccurs="0"/> > >>>> <xs:element name="tomcat-realm" type="xs:string" > >>>>minOccurs="0"/> > >>>> </xs:sequence> > >>>> </xs:complexType> > >>>> > >>>>- <xs:complexType name="emptyType"/> > >>>>- > >>>>+ <xs:simpleType name="trueFalseType"> > >>>>+ <xs:restriction base="xs:string"> > >>>>+ <xs:enumeration value="true"/> > >>>>+ <xs:enumeration value="false"/> > >>>>+ </xs:restriction> > >>>>+ </xs:simpleType> > >>>>+ > >>>> </xs:schema> > >>>> > >>>> >
