[ http://issues.apache.org/jira/browse/GERONIMO-1223?page=all ]
Gao Yong Pan updated GERONIMO-1223:
-----------------------------------
Description:
The method getLastModifiedInDir in the
hot-deploy/src/java/org/apache/geronimo/deployment/hot/DirectoryMonitor.java is
using the algorithm by calculating highest modified time of any files or
directories, this could be improved.
In fact, we only need to check every directory is enough, because any changes,
for example, add, remove, edit any files in a directory, the change can be
reflected by its current directory's modification time, so we don't need to
check files.
I also write a patch for the issue. A simple performance testing shows that the
patch will improve 58% of the performance.
was:
The method getLastModifiedInDir in the
hot-deploy/src/java/org/apache/geronimo/deployment/hot/DirectoryMonitor.java is
using the algorithm by calculating highest modified time of any files or
directories, this could be improved.
In fact, we only need to check every directory is enough, because any changes,
for example, add, remove, edit any files in a directory, the change can be
reflected by its parent directory's modification time, so we don't need to
check files.
I also write a patch for the issue. A simple performance testing shows that the
patch will improve 58% of the performance.
> Hot Deploy performance improvement Just check directories -patch available
> --------------------------------------------------------------------------
>
> Key: GERONIMO-1223
> URL: http://issues.apache.org/jira/browse/GERONIMO-1223
> Project: Geronimo
> Type: Improvement
> Components: deployment
> Versions: 1.0
> Environment: linux or windows
> Reporter: Gao Yong Pan
> Attachments: DirectoryMonitor.java.patch
>
> The method getLastModifiedInDir in the
> hot-deploy/src/java/org/apache/geronimo/deployment/hot/DirectoryMonitor.java
> is using the algorithm by calculating highest modified time of any files or
> directories, this could be improved.
> In fact, we only need to check every directory is enough, because any
> changes, for example, add, remove, edit any files in a directory, the change
> can be reflected by its current directory's modification time, so we don't
> need to check files.
> I also write a patch for the issue. A simple performance testing shows that
> the patch will improve 58% of the performance.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
