On Feb 14, 2006, at 10:03 AM, Joe Bohn wrote:
David,
Thanks for the clarification. I'm still having some problems
understanding our classloader construction ... so can I ask for a
little more clarification?
When I encountered this problem it was because I had removed 3
derby dependencies (geronimo-derby, derby, and derbynet) from
config j2ee-server. Daytrader had a parent of j2ee-server ... so
it makes sense that this change could have affected daytrader. I
had a fix that I hadn't made available yet where I added the
dependencies directly into daytrader for these same three derby
configs. However, I noticed that you chose instead to add system-
database (which also included these 3 dependencies) as a parent of
daytrader. What additional benefits does this provide?
I don't think your change would have worked, since I believe it would
have still resulted in 2 copies of the derby classes being loaded and
the derby engine (started and loaded from the system-database config)
being in a different classloader than the jdbc classes trying to use
it in the daytrader app.
Making daytrader a child of system-database forces all the classes to
come from the system-database classloader.
Also, I'm working on additional updates. Would you prefer to have
individual JIRAs for these items or larger ones with more "bang for
buck" in reducing the size of minimal? What I have right now
doesn't provide a lot of additional savings yet.
I think I might be happiest with a single jira item with mutliple
patches on it: when we decide we can't get any smaller we can close it.
thanks
david jencks
Thanks,
Joe
David Jencks (JIRA) wrote:
[ http://issues.apache.org/jira/browse/GERONIMO-1613?
page=comments#action_12366301 ] David Jencks commented on
GERONIMO-1613:
----------------------------------------
To be a little clearer, I fixed the derby problems in daytrader
also. r377628
Eliminate unncessary dependencies to reduce assemnbly footprint size
--------------------------------------------------------------------
Key: GERONIMO-1613
URL: http://issues.apache.org/jira/browse/GERONIMO-1613
Project: Geronimo
Type: Improvement
Components: general
Versions: 1.1
Environment: all
Reporter: Joe Bohn
Assignee: David Jencks
Fix For: 1.1
Attachments: RemoveDeps.patch
Clean up assembly project.xml and eliminate some unnecessary
dependencies in various modules and configs. This will reduce
the footprint size (with special attention to the minimal-tomcat-
assembly.
The patch contains the following:
- clean up minimal-tomcat-server\project.xml to remove commented
out sections
- clean up web-jms-tomcat-server\project.xml to remove commented
out sections
- remove dependencies from config\j2ee_server on xstream, jaxr-
api, and geronimo-derby
- remove dependencies from config\j2ee_deployer on geronimo-
client-builder
- remove dependencies from module\tomcat on activecluster, wadi-
core, and wadi-tomcat55
There are still more dependencies that should be removed but this
is a start.
These changes reduce the disk footprint of minimal-tomcat-server
from 27 meg to about 21 meg.
--
Joe Bohn
joe.bohn at earthlink.net
"He is no fool who gives what he cannot keep, to gain what he
cannot lose." -- Jim Elliot
