[ http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12367066 ]
Jeff Genender commented on GERONIMO-1035: ----------------------------------------- Yes, please do not include broken Unit tests. All Unit tests have to pass, or it breaks the build. As I stated before, please be sure you can apply your patches and completely build Geronimo, and it all must compile and all the tests must pass before we can even begin to think about using this code. Your changes in code can impact other modules, so this is very important that this works. If the broken test is testing (/*) issues, then I would suggest that you leave the unit test but test that the proper error was thrown. That would be a valid test case for your change. Also the xml files need to be cleaned up as well. Please format them appropriately and supply a new patch for the Tomcat builder, so we can proceed forward. > tomcat integration should wrap each servlet indiviudally > -------------------------------------------------------- > > Key: GERONIMO-1035 > URL: http://issues.apache.org/jira/browse/GERONIMO-1035 > Project: Geronimo > Type: New Feature > Components: Tomcat > Versions: 1.0-M5 > Environment: All > Reporter: Anita Kulshreshtha > Assignee: Jeff Genender > Fix For: 1.1 > Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, > management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, > tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch > > TomcatModuleBuilder should wrap each servlet specified in the deployment > descriptor individually. This is needed by JSR-77 and for gathering tomcat > internal statistics. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
