[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370808 ]
Greg Wilkins commented on GERONIMO-1686: ---------------------------------------- > * GenericServlet calls super() when it does not need to. > More specifics would be good here. I've changed the code though to look more > like the <= 2.4 code which could clear things up. super() is called by default anyway... so it is just not needed. > * In GenericServlet, the initParameter, getServletContext and getServletName > methods are now all protected with an IllegalStateException if the > ServletConfig is null (ie if init(ServletConfig) has been overriden and does > not call > super). > This is mandated by the spec now. > I could not find anywhere in the 2.5 spec that spelled this out. However I > totally agree that IllegalStateException is much better than > NullPointerException so I updated the code to throw ISE instead of NPE. If > you could point me to the spec bits that specify this I'd be glad to make > sure the spec is being followed. I'm not sure if the version that mandates it is released. Besides I think it is specified in the javadoc rather than the spec itself. > * geronimo is using @override and @deprecated which I think is needless java5 > featurism (I know java5 is required for compliance.... but there is nothing > in the rest of the javax classes that needs it). > > Does it matter one way or the other? I'm fine either way. Unchanged in this > patch. It stops this source being used for 1.4 based servlet containers... when there is no need to. I don't think these anotations add enough value to make that worthwhile (yet). > Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work > -------------------------------------------------- > > Key: GERONIMO-1686 > URL: http://issues.apache.org/jira/browse/GERONIMO-1686 > Project: Geronimo > Type: New Feature > Reporter: Bill Dudney > Assignee: Jeff Genender > Priority: Minor > Attachments: jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch > > I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the > week of 3/6/06. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
