[ http://issues.apache.org/jira/browse/GERONIMO-2069?page=all ]
     
John Sisson closed GERONIMO-2069:
---------------------------------

    Resolution: Fixed

Fixed.  Users will now get a more useful error giving the file name, line and 
column number.

C:\testx>geronimo-1.1-SNAPSHOT\bin\geronimo.bat run --long
Using GERONIMO_HOME:   C:\testx\geronimo-1.1-SNAPSHOT
Using GERONIMO_TMPDIR: C:\testx\geronimo-1.1-SNAPSHOT\var\temp
Using JRE_HOME:        C:\j2sdk1.4.2_10
Booting Geronimo Kernel (in Java 1.4.2_10)...
00:09:55,937 ERROR [LocalAttributeManager] Unable to read saved manageable 
attributes.SAX parse error: cvc-complex-type.2.4.b: The c
ontent of element 'pattern' is not complete. One of 
'{"http://geronimo.apache.org/xml/ns/attributes-1.1":groupId, "http://geronimo.a
pache.org/xml/ns/attributes-1.1":artifactId, 
"http://geronimo.apache.org/xml/ns/attributes-1.1":version, 
"http://geronimo.apache.org
/xml/ns/attributes-1.1":type, 
"http://geronimo.apache.org/xml/ns/attributes-1.1":module, 
"http://geronimo.apache.org/xml/ns/attribut
es-1.1":name}' is expected. at line 72, column 19 in entity 
file:///C:/testx/geronimo-1.1-SNAPSHOT/var/config/config.xml
Module  1/20 geronimo/rmi-naming/1.1-SNAPSHOT/car              started in   
.297s

> o.a.g.system.configuration.LocalAttributeManager.load() does not 
> setErrorHandler when parsing
> ---------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-2069
>          URL: http://issues.apache.org/jira/browse/GERONIMO-2069
>      Project: Geronimo
>         Type: Bug
>     Security: public(Regular issues) 
>   Components: startup/shutdown
>     Versions: 1.1
>     Reporter: John Sisson
>     Assignee: John Sisson
>     Priority: Minor
>      Fix For: 1.1

>
> There are two issues in the load() processing:
> * If a validation error occurs, the file containing the error isn't 
> identified.  The code needs to use inputsource.setSystemId(..) so the errors 
> from the parser identify the config.xml file, rather than displaying URI=null.
> * No error handler is set up, so a warning message is issued from Xerces.
> If the config.xml file is invalid, startup will produce output similar to the 
> following:
> $./geronimo.sh run --long
> Using GERONIMO_BASE:   
> /home/sissonj/OpenSourceJava/asf/geronimo/branches/1.1/assemblies/j2ee-tomcat-server/target/geronimo-1.1-SNAPSHOT
> Using GERONIMO_HOME:   
> /home/sissonj/OpenSourceJava/asf/geronimo/branches/1.1/assemblies/j2ee-tomcat-server/target/geronimo-1.1-SNAPSHOT
> Using GERONIMO_TMPDIR: 
> /home/sissonj/OpenSourceJava/asf/geronimo/branches/1.1/assemblies/j2ee-tomcat-server/target/geronimo-1.1-SNAPSHOT/var/temp
> Using JRE_HOME:        /usr/j2se
> Booting Geronimo Kernel (in Java 1.4.2_10)...
> Warning: validation was turned on but an org.xml.sax.ErrorHandler was not
> set, which is probably not what is desired.  Parser will use a default
> ErrorHandler to print the first 10 errors.  Please call
> the 'setErrorHandler' method to fix this.
> Error: URI=null Line=74: cvc-complex-type.2.4.b: The content of element 
> 'reference' is not complete. One of 
> '{"http://geronimo.apache.org/xml/ns/attributes-1.1":pattern}' is expected.
> Module  1/20 geronimo/rmi-naming/1.1-SNAPSHOT/car              started in   
> .594s
> <SNIP>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to