Jason Dillon wrote:
So far 2+ days, several patches... one PMC +1, one non-PMC +1 (with
caveat to ping JVZ)... now crazy problems with diff/patch.. which I'm
not exactly sure how that affects the current votes... or does adding
a new version of the patch negate anything else voted upon.
IMO, a vote for a patch would be need to be restarted if the changes
between the previous patch and the newer version of the patch are not
trivial. Trival meaning:
* documentation changes
* non-controversial non-semantic style changes such as fixing
indentation and adding comments.
Trivial changes do not include code changes or changes that affect the
operation of the build.
To make it easier for reviewers when a new version of a patch is
generated, it would be worthwhile adding a comment on what has changed
since the previous patch.
Do the above patch vote negation guidelines sound reasonable to everyone?
Thanks,
John
