I have not had time to fully review the patch, but here are a few remarks.
Some existing components may already expose a WSDL 1.1 (as WSDL 2.0 is not supported yet) which may contain a soap binding. While this is not a good thing, we need to cope with them. That' s the reason why I don't really like the mechanism to auto-discover the WSDL and engage the WSDL 1.1 normalization if the target endpoint WSDL contain a soap binding. I think this should be configured with a flag on the http consumer endpoint. And existing components should be enhanced to use this normalization (but that' s another problem). Another slight oversight I think, is that the SoapHelper#findOperation should only check the WSDL for the current endpoint, and this WSDL should be modified according to the binding used. We should also provide a way to easily configure the binding with default values (let's say just doclit / rpc) by setting a flag on the http endpoint. So, while I think this is a really good patch that enhance the current http component, it is part of a bigger feature. It may even be linked to WSDL 2.0 support, or full rest support. If I find enough time (may not be this week), I'll try to handle these two points in a simple way for the moment, so that this great and needed feature can be used. But if you want to take a look at it, feel free to do so. Also, I think I have seen some removed / commented features about security. I think this is a patch I applied recently... On 8/25/06, Alex Boisvert <[EMAIL PROTECTED]> wrote:
Hi all, To follow-up on prior discussion around normalization, I've now created a patch <https://issues.apache.org/activemq/browse/SM-557> [1] that provides WSDL 1.1 normalization for the servicemix-http component. More specifically, the code provides a set of reusable classes for converting between SOAP 1.1 messages and JBI messages using WSDL 1.1 definitions. This code now sits in the servicemix-soap shared library and I should mention that it's fairly strict about WS-I BasicProfile compliance to reduce complexity and encourage people to write interoperable service definitions. I have not implemented a flag to turn normalization on/off. It should be pretty simple but I figured I'd throw it out there to see how people want to configure this (e.g. in the WSDL?) Feedback on the patch itself or the configuration aspect would be appreciated. cheers, alex [1] https://issues.apache.org/activemq/browse/SM-557
-- Cheers, Guillaume Nodet
