Maybe we can make this builder use the testsupport deployables... or maybe we need to make a new test deployment for it. Or if all of the tomcat support was under a geronimo-tomcat module of type pom, then it could define its own test deployments as normal modules.

--jason


On Aug 31, 2006, at 2:55 PM, Jacek Laskowski wrote:

On 8/29/06, Sergey Elin <[EMAIL PROTECTED]> wrote:

there is a number of class files in trunk. Any reasons for it?

Other than there're there for the tests? No.

Seriously, there're in trunk as they're simply resources for tests (am
I repeating myself?).

[EMAIL PROTECTED] /cygdrive/c/oss/geronimo/modules/geronimo-tomcat- builder/src/test/resources/deployables/war4/WEB-INF/classes/org/ apache/geronimo/tomcat/app
$ svn log Servlet1.class
...
---------------------------------------------------------------------- -- r164651 | jgenender | 2005-04-25 23:09:26 +0200 (Mon, 25 Apr 2005) | 1 line

New tomcat-builder
---------------------------------------------------------------------- --

Jeff added them likely to not have bothered to script their
compilation and proper inclusion in the resources directories of these
tests (Jeff? Are you reading this? ;-) ).

I think you can go and improve it a little. Create a JIRA task and get
rid of them. Let's fix it by creating their java sources and let Maven
know about the change.

Ready to give it a spin? Ask when in trouble.

Jacek

--
Jacek Laskowski
http://www.laskowski.net.pl

Reply via email to