[ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12433923 ] Paul McMahan commented on GERONIMO-2333: ----------------------------------------
Chris the new portlet looks fantastic!! It will be a huge help for administrators and developers needing to explore the server. I especially like the well designed use of ajax controls. A few comments to consider before this is committed. I would be happy to help follow up on any of these items, just let me know: - I think that the dojo license is compatible with ASL but before embedding it in the server I think the Geronimo PMC should be notified and allowed to make an "official" decision on its inclusion - At one time there was an attempt to convert all use of ObjectName over to AbstractName so certain deprecated methods could be removed from the kernel, but I don't know where that stands now. If replacing ObjectNames with AbstractNames is not simple then can you check on the dev list to see if introducing more of use of it creates any concern? - A few new files need copyright headers (e.g. viewJMXServer.jsp) - Since this is a new feature can you provide a patch for trunk instead of the 1.1.x branch? I think the only real difference in trunk is that the console directories were moved. - The "JMX Viewer" link in the Console Navigation area should maybe go in the Server folder instead of a new top level item. But I can go either way if there are strong opinions otherwise. - Need to test on safari, konqueror, and opera. I'll do this tonight if possible and update the JIRA with results. - Later we may want to separate the dojo library into a plugin like was discussed on the dev list. I think the way you've implemented this portlet will facilitate that approach, is that true? Here are a few suggestions for if /when you or someone else want to make some improvements. IMO these changes are not required before commiting. - When a user clicks on a leaf node it loads data into the notebook area. To avoid confusion I recommend clearing that data when they click on a group node. - At first it wasn't obvious to me that there's a lot more data in the notebook area if you scroll right. If the dojo table widget can do resizable columns then that would help. - It would be nice if the mouse pointer glyph changed to an hour glass while data was loading from the server. For example, some actions like initial bringup, loading data into the notebook area, or expanding the "All MBeans-->geronimo" node take several seconds. Providing an indication that the UI was processing their request would keep them from re-clicking or wondering if the UI is hung. Again, nice work! > Add JMX Portlet > --------------- > > Key: GERONIMO-2333 > URL: http://issues.apache.org/jira/browse/GERONIMO-2333 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: console > Affects Versions: 1.2 > Reporter: Chris Cardona > Assigned To: Chris Cardona > Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, > jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, > jmxMgrPortlet-G1.1.1-New.patch, jmxMgrPortlet-G1.1.1.patch > > > Add a JMX portlet with the following minimum capabilities: > 1. Be able to list all the MBeans > 2. Predefined searches for the different J2EE types: J2EEApplication, > EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc. > 3. Be able to query MBeans (if possible with autocomplete feature) > 4. View the attributes and operations of MBeans > The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit > responsive. Any thoughts and suggestions are welcome. > cheers, > chris -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
