[ https://issues.apache.org/activemq/browse/SM-536?page=comments#action_37401 ] Grant McDonald commented on SM-536: -----------------------------------
I was having a look at the patch again and I've got a question. in the deploy on AbstractXBeanDeployer we have the following code snippet: if (validate(endpoint)) { su.addEndpoint(endpoint); } else { logger.warn("Endpoint " + endpoint + "has not been validated"); } And in the validate method on the AbstractXBeanDeployer we have: protected boolean validate(Endpoint endpoint) throws DeploymentException { endpoint.validate(); return true; } The problem with this is that when there is a validation error the endpoint does throw a DeploymentException which means that it exits the deploy method and we never get the warning message. So was the intent that endpoint validation errors should always be a warning or should we remove the validate method and just call endpoint.validate() instead? > The defaultMep is a mandatory attribute on consumer endpoints and should be > checked > ----------------------------------------------------------------------------------- > > Key: SM-536 > URL: https://issues.apache.org/activemq/browse/SM-536 > Project: ServiceMix > Issue Type: Bug > Components: servicemix-http, servicemix-jms > Reporter: Guillaume Nodet > Assigned To: Grant McDonald > Attachments: SM-536.patch > > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira