[ http://issues.apache.org/jira/browse/DAYTRADER-14?page=comments#action_12449738 ] Christopher James Blythe commented on DAYTRADER-14: ---------------------------------------------------
Piyush... I really like what you have here... It's clean, simple, and makes working with the default derby database so much easier. We no long have to run and external sql script or provide a pre-built derby database. Actually, I went ahead and changed the deployment plans in Daytrader-24 to create the derby db by default. Just a few more comments... - I like how feedback is written to the page while created the db. How do you feel about writing out the status for each sql command that is executed instead of waiting for all of them to complete. If for some reason, one were to fail it would be nice to see it in the browser screen. That way we don't have to dig through the logs to see what happened. - Looks like there might be a type of two in your trace/error statements... In TradeDirect.java - "thrown on executing the [foll] sql command:" - We need to sync up the ddl files - specifically, the indexes. I will create another JIRA to address this. Chris > Include sql script in the ear and use a gbean to create tables etc > ------------------------------------------------------------------ > > Key: DAYTRADER-14 > URL: http://issues.apache.org/jira/browse/DAYTRADER-14 > Project: DayTrader > Issue Type: Improvement > Components: EJB Tier > Affects Versions: 1.2 > Reporter: David Jencks > Attachments: d-j-plan.xml, DAYTRADER-14.patch, daytrader-14.patch.1019 > > > You can use the DatabaseIntitializationGBean (GERONIMO-2396) in a g. plan and > include the sql script in the ejb module so the database will get created if > not already present. This is way better than the previous hack of including a > pre-built database in the car file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
