[ http://issues.apache.org/jira/browse/GERONIMO-2621?page=all ]
Rakesh Midha updated GERONIMO-2621:
-----------------------------------
Attachment: deployExp.patch
As discussed in discussion thread
http://comments.gmane.org/gmane.comp.java.geronimo.devel/41449
This patch provides following improvements for configManager view of console.
I am supplying this patch as a sample for coming up with a guidelines to
exception handling and info/warning printing.
Here is what is done to handle exception in console:
1. ConsoleException.java which extends PortletException, this class will have
overridden printStackTrace(PrintWriter), which will set attribute required in
_ConsoleException.jsp apart from printing the stack on PrintWriter. For now
logging is not used and printStackTrace() prints exception on web console and
server console.
2. Create _ConsoleException.jsp which should be included in all portlet, this
jsp will be responsible to print a short message and long stack trace. (with a
toggle button to view and hide long stack trace and dojo dialog link). We need
to select one from toggle button and dojo dialog, for now i ave included both.
4. In BasePortlet added printInfo, printWarning, printError and printFullError.
Apart from console exception these methods can be used to print info, warning,
error or full exception to web console. All Info and full exceptions will be
printed in black, warnings in yellow and Error in red font.
5. DeploymentPortlet class throws ConsoleException instead of PortletException
6. DeploymentPortlet class also use printInfo, printWarning metods
To view the effect of patch:
Apply the patch
Using deploy new page, try to redeploy an application which is not deployed.
This will print a short exception and detailed exception.
If this protocol is accepted I will provide a patch for other portlets also.
thanks
> Exception handling in Console
> -----------------------------
>
> Key: GERONIMO-2621
> URL: http://issues.apache.org/jira/browse/GERONIMO-2621
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.0
> Reporter: Rakesh Midha
> Assigned To: Rakesh Midha
> Fix For: 2.0
>
> Attachments: deployExp.patch
>
>
> This improvement is discussed in
> http://comments.gmane.org/gmane.comp.java.geronimo.devel/41449
> In case I get any exception or error condition in Console, the nothing is
> printed on web console and huge stack trace is printed on server console.
> Only thing done in the name of Exception handling in all the portlets is
> "throw PortletException"
> I somehow don't like this behavior of console. As a console user I don't want
> to go and see server stacktrace, if there is some error I should atleast be
> informed in console. I think everytime there is a error or exception in
> console, it should be printed in either exception page in webconsole, or in
> header of portlet view page. This is done to some extent in configManager and
> CA part of console. But not in uniform way.
> This is what I am proposing for Exception handling in console :
> 1. Create a ConsoleException.java which extends PortletException, this class
> will have overridden printStackTrace(PrintWriter), which will set attribute
> required in _ConsoleException.jsp apart from printing the stack on
> PrintWriter.
> 2. Create _ConsoleException.jsp which should be included in all portlet, this
> jsp will be responsible to print a short message and long stack trace. (with
> a toggle button to view and hide long stack trace)
> 3. All Portlet classes should throw ConsoleException instead of
> PortletException
> I think this will be nice and cleaner way to handle the console problems.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
