But why do we want to use "jetty5" and then "jetty6" all in the same
branch?
I don't think the version should be here.
Actually I don't think that we need a version for the jee5 stuff
either. It should be jee, or probably javaee, adding the version
just means that every release we will have to change the name of the
module and reconfigure everything. There was j2ee before, which was
effectively the same as jee, it was not j2ee14, which would be the
same as the jee5 that we have now. I don't think there is a plan to
support more than one version of teh java enterprise edition per G
server release, therefor the addition of spec version to our modules
is unneeded and adds extra complexity which we should lean away from.
Same thing with jetty/tomcat integration... I don't think we want to
(or plan to) support more than one version of these per G server
release, so the version here in the assembly id just complicates
usage. Meaning when jetty7 is out, then not only do you have to
configure the assembly config with the new artifactId, you also have
to go configure everyone who is using that assembly to use the new
id, that rather negates some of the purpose of that id... its an
alias... saying give me the G server that has jetty.
Blah... I'm just trying to keep build configuration complexity in
check... but I'm getting a bit tired of trying :-\
--jason
On Dec 11, 2006, at 7:04 AM, Prasad Kashyap wrote:
I agree with you. But then I thoght I'd use the -DassemblyId param in
one other place in the testsuite; the console-testsuite. The
webconsole-tomcat6 or webconsole-jetty6 car needs to be started and
stopped in the console-testsuite. Instead of using yet another config
param, I thought we could reuse the -DassemblyId.
However, this whole thing is supposed to be temporary. This hack of
getting the container name, the container name itself having the
version number in it, everything. Which is why I didn't modify
"tomcat6" back to "tomcat"
Cheers
Prasad
1) There must be a better way to get the container type, either from
the running server or from geronimoHome or some such place, instead of
using too many
On 12/11/06, Jason Dillon <[EMAIL PROTECTED]> wrote:
Why are we giving the assembly id's the version suffix here? I don't
think we want to do this. I think the ids, which are simply to
select which assembly to use should be tomcat or jetty. IMO, this is
just that much more to type... for no real gain.
These are assembly ids, not artifact ids... they are supposed to be
short and simple. IMO this change only complicates them slightly by
forcing people to remember which jetty version they are using. And I
hope that we are not going to start supporting a bunch of different
jetty or tomcat versions per codeline... that would be a huge,
massive, ugly mess.
I recommend reverting this change, and changing the id's of the
tomcat6* bits to tomcat*.
--jason
On Dec 10, 2006, at 7:22 PM, [EMAIL PROTECTED] wrote:
> Author: prasad
> Date: Sun Dec 10 19:22:47 2006
> New Revision: 485477
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=485477
> Log:
> * changing assemblyId to jetty6 to make it consistent with tomcat6
>
> Modified:
> geronimo/server/trunk/pom.xml
>
> Modified: geronimo/server/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml?
> view=diff&rev=485477&r1=485476&r2=485477
>
=====================================================================
=
> ========
> --- geronimo/server/trunk/pom.xml (original)
> +++ geronimo/server/trunk/pom.xml Sun Dec 10 19:22:47 2006
> @@ -1256,7 +1256,7 @@
> <configuration>
> <assemblies>
> <assembly>
> - <id>jetty</id>
> + <id>jetty6</id>
>
> <groupId>org.apache.geronimo.assemblies</groupId>
> <artifactId>geronimo-jetty6-jee5</
> artifactId>
> <version>${version}</version>
> @@ -1265,7 +1265,7 @@
> </assembly>
>
> <assembly>
> - <id>jetty-minimal</id>
> + <id>jetty6-minimal</id>
>
> <groupId>org.apache.geronimo.assemblies</groupId>
> <artifactId>geronimo-jetty-
> minimal</artifactId>
> <version>${version}</version>
> @@ -1292,7 +1292,7 @@
> </assembly>
> </assemblies>
>
> - <defaultAssemblyId>jetty</
defaultAssemblyId>
> + <defaultAssemblyId>jetty6</
defaultAssemblyId>
>
> <optionSets>
> <optionSet>
>
>
