Based on your description, and assuming that you added geronimo-gbean-
deployer as a classes-only dependency, I think this is ok. Did you
check that the deployer jar works both online and offline? If you
supply a patch I'll look in more detail, but I don't think that's
necessary.
thanks
david jencks
On Mar 8, 2007, at 9:07 AM, Anita Kulshreshtha wrote:
David J,
I want to make sure that I have not overlooked anything.. Things
seem
to be working with these changes. They are waiting for your blessing..
Thanks
Anita
--- Anita Kulshreshtha <[EMAIL PROTECTED]> wrote:
I added connector-deployer as a 'import classes' dependency of
jsr88-rar-configurer as you had suggested. I could get it to start
only
after adding gbean-deployer as a parent of jsr88-cli because of the
following error:
18:19:36,500 WARN [ConfigurationUtil] Could not load gbean
org.apache.geronimo.configs/jsr88-rar-configurer/2.0-SNAPSHOT/car?
ServiceModule=org.apache.geronimo.configs/jsr88-rar-configurer/2.0-
SNAPSHOT/car,j2eeType=DeploymentConfigurer,name=RARConfigurer
org.apache.geronimo.gbean.InvalidConfigurationException: Getter
return
type in wrong classloader: type: class
javax.enterprise.deploy.shared.ModuleType wanted in classloader:
[org.apache.geronimo.kernel.classloader.JarFileClassLoader
id=org.apache.geronimo.configs/jsr88-cli/2.0-SNAPSHOT/car] actual:
[org.apache.geronimo.kernel.classloader.JarFileClassLoader
id=org.apache.geronimo.configs/geronimo-gbean-deployer/2.0-SNAPSHOT/
car]
at
org.apache.geronimo.gbean.runtime.GBeanAttribute.<init>
(GBeanAttribute.java:241)
How does this fit with other things?
Thanks
Anita
--- David Jencks <[EMAIL PROTECTED]> wrote:
I agree that starting the existing jsr88-* configs is a better
solution than adding gbeans to the deployer configs. There might
possibly be classloading problems from duplicate copies of e.g.
geronimo-connector-builder.jar, but if that happens I think the
better solution is to move the jsr88 code into separate jars,
something I believe Aaron and I have been contemplating for years.
I'm glad to know that there is already a LocalDeploymentManager.
thanks
david jencks
On Mar 6, 2007, at 9:11 AM, Gianny Damour wrote:
Hello Anita,
I had a quick look to GERONIMO-2916 and, as per David J. comment,
it seems to me that if you simply start the pointed out modules
this bug will be fixed: DatabasePoolPortlet gets a
LocalDeploymentManager instance, which knows about all the
running
ModuleConfigurer GBean implementations. If
org.apache.geronimo.configs/jsr88-rar-configurer//car is started,
then you will get a RARConfigurer running within the server. Then
when DatabasePoolPortlet obtains its LocalDeploymentManager, this
latter does know about RARConfigurer.
Thanks,
Gianny
On 07/03/2007, at 12:18 AM, Anita Kulshreshtha wrote:
Minor (? :)) Clarification....
David, I meant to write connector-deployer config not
system-database to add the GBean to. Will that change your
answer?
I
think having individual GBeans in the appropriate deployer
config
will
work well for minimal and framework servers.
Thanks
Anita
--- Anita Kulshreshtha <[EMAIL PROTECTED]> wrote:
--- David Jencks <[EMAIL PROTECTED]> wrote:
On Mar 5, 2007, at 6:31 PM, Anita Kulshreshtha wrote:
I need to add RARConfigurer GBean to system-database
config
to
fix
https://issues.apache.org/jira/browse/GERONIMO-2916 (see
excerpts
below)
Is this the correct place to add it?
No.
Instead of adding gbeans to anything, I think you want to
start
all
the jsr88-*configurer modules gianny recently added. See
assemblies/
geronimo-jetty6-jee5/src/main/var/config/jsr88-configurer-config.xml
which contains
<module
name="org.apache.geronimo.configs/jsr88-cli/${version}/car"/>
<module
name="org.apache.geronimo.configs/jsr88-jar-configurer/$
{version}/car"/>
<module
name="org.apache.geronimo.configs/jsr88-rar-configurer/$
{version}/car"/>
<module
name="org.apache.geronimo.configs/jsr88-war-configurer/$
{version}/car"/>
<module
name="org.apache.geronimo.configs/jsr88-ear-configurer/$
{version}/car"/>
I don't think you want to start the jsr88-cli in the server.
If
there isn't already an appropriate gbean for the
DeploymentManager
we'd need a gbean like
<gbean name="ModuleConfigurerRegistry"
class="org.apache.geronimo.deployment.plugin.jmx.RemoteDeploymentMana
ger
">
<references name="ModuleConfigurers">
<pattern>
<name>ClientConfigurer</name>
</pattern>
<pattern>
<name>EARConfigurer</name>
</pattern>
<pattern>
<name>RARConfigurer</name>
</pattern>
<pattern>
<name>WARConfigurer</name>
</pattern>
</references>
</gbean>
somewhere appropriate but I don't think it should be the
jmxRemoteDeploymentManager. (but I'm not sure) It does need
to
be
able to accept the *Configurers registering with it.
I found WARConfigurer GBean in tomcat6-deployer config. I
did
not
find any EarConfigurer. I am still mesmerized by this stuff...
The
ModuleConfigurerRegistry is a good choice. Where should this
GBean
go?
Thanks
Anita
thanks
david jencks
Thanks
Anita
........................................................
5:07:55,562 ERROR [DatabasePoolPortlet] Unable to save
connection
pool
javax.enterprise.deploy.spi.exceptions.InvalidModuleException:
No
=== message truncated ===
______________________________________________________________________
______________
Expecting? Get great news right away with email Auto-Check.
Try the Yahoo! Mail Beta.
http://advision.webevents.yahoo.com/mailbeta/newmail_tools.html
