Are you also going to check this into the 2.1 branch? The JIRA shows that it was fixed for 2.1.1, but trunk is 2.2.....

-Donald


Jarek Gawor (JIRA) wrote:
[ https://issues.apache.org/jira/browse/GERONIMO-3802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569043#action_12569043 ]
Jarek Gawor commented on GERONIMO-3802:
---------------------------------------

Committed the patch to trunk (revision 627838). Thanks!

I've noticed a few more minor issues that can be improved with the portlet:

1) At minimum the user should provide an artifact id otherwise assembly named --bin.tar.gz will be created. The portlet should check for empty artifact id.
2) If no plugins are selected and 'assemble' button is pressed a nasty 
exception will be displayed. The portlet should check if at least one plugin 
was selected.

3) On the confirmation screen and on Windows the server path location will 
contain / and \. For example c:\geronimo/var/temp/foo.tar.gz.



In plugin installer, assembling a server, add a page at the end to confirm or 
deny the assembly of a server package.
--------------------------------------------------------------------------------------------------------------------

                Key: GERONIMO-3802
                URL: https://issues.apache.org/jira/browse/GERONIMO-3802
            Project: Geronimo
         Issue Type: Improvement
Security Level: public(Regular issues) Components: console
   Affects Versions: 2.1, 2.1.1
           Reporter: Joseph Leong
           Assignee: Jarek Gawor
           Priority: Minor
            Fix For: 2.1.1

        Attachments: GERONIMO-3802.patch


Add a type of confirmation page at the end of Assembling a server to inform the 
user whether the creation of there server was successful or not.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to