[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620039#action_12620039
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-325:
------------------------------------------------

HI Ashish, thanks for working on this and you seem to be getting much closer. 
There are still a couple small problems though:

1. When using the "Download and Install" button, it forces me to browse to a 
location whereas before it used to allow me to enter a directory of my choice 
manually. It's probably better to allow both manual entry and the usage of the 
Browse button and let the user decide which they would like to do. 
2. It's a bit confusing having one variable named installDir (with uppercase 
'D') and another one named installdir (with lowercase 'd')
3. After the "Download and Install" button is clicked, the GEP does in fact 
download the zip file for the server. It should then populate the installation 
directory text field so that the "Next" or "Finish" button can be immediately 
clicked. As it is now with your patch, it forces the user to Browse to the 
installation directory, which is not what we want. 

> "Download and Install" button should be disabled/enabled appropriately
> ----------------------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-325
>                 URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-325
>             Project: Geronimo-Devtools
>          Issue Type: Bug
>          Components: eclipse-plugin
>    Affects Versions: 2.1.2
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Trivial
>             Fix For: 2.1.2
>
>         Attachments: GERONIMODEVTOOLS-325.patch
>
>
> After selecting which server I want to use, the "Application Server 
> Installation Directory" field is blank and the "Download and Install" button 
> is enabled.  Hitting this button does nothing -1) it should be disabled on 
> the page when the page is first shown.
> If I enter a directory that does not exist, a message shows at the top of the 
> dialog saying "The specified directory does not exist".  2) the button should 
> be disabled when that message appears and enabled when one of the "download 
> allowable" messages appears (there seem to be several).
> 3) Also, in stead of disabling for 2), it would be slightly more usable to 
> allow the user to click the "Download and Install" button and then ask the 
> user if they wanted to create that directory.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to