Re: svn commit: r682592 - /geronimo/server/branches/2.1/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/configmanager/DeploymentPortlet.java

[YunFeng Ma]

Kevan, thanks for this kind remind and I'd like to get your more reminder if I 
do something improperly, I'm still newbie to opensource community, :-)    
Thanks a lot.

-- YunFeng



----- Original Message ----
From: Kevan Miller <[EMAIL PROTECTED]>
To: dev@geronimo.apache.org
Sent: Thursday, August 7, 2008 10:34:33 AM
Subject: Re: svn commit: r682592 - 
/geronimo/server/branches/2.1/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/configmanager/DeploymentPortlet.java

YunFeng,
When applying a patch that is supplied by someone else, please note their name 
(preferably their full name) in your commit message. For example:

GERONIMO-4227 Apply patch from Ivan. Incorrect message is show even if the 
deployment failed in the web console

Thanks. 

--kevan


On Aug 5, 2008, at 2:06 AM, [EMAIL PROTECTED] wrote:

Author: yunfengma
Date: Mon Aug  4 23:06:32 2008
New Revision: 682592

URL: http://svn.apache.org/viewvc?rev=682592&view=rev
Log:
GERONIMO-4227 Incorrect message is show even if the deployment failed in the 
web console

Modified:
   
geronimo/server/branches/2.1/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/configmanager/DeploymentPortlet.java

Modified: 
geronimo/server/branches/2.1/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/configmanager/DeploymentPortlet.java
URL: 
http://svn.apache.org/viewvc/geronimo/server/branches/2.1/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/configmanager/DeploymentPortlet.java?rev=682592&r1=682591&r2=682592&view=diff
==============================================================================
--- 
geronimo/server/branches/2.1/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/configmanager/DeploymentPortlet.java
 (original)
+++ 
geronimo/server/branches/2.1/plugins/console/plugin-portlets/src/main/java/org/apache/geronimo/console/configmanager/DeploymentPortlet.java
 Mon Aug  4 23:06:32 2008
@@ -161,7 +161,12 @@
                        while(progress.getDeploymentStatus().isRunning()) {
                            Thread.sleep(100);
                        }
-                        abbrStatusMessage+="The application was successfully 
started";
+                        if (progress.getDeploymentStatus().isCompleted()) {
+                            abbrStatusMessage += "The application was 
successfully started";
+                        } else {
+                            abbrStatusMessage += "The application was not 
successfully started";
+                            fullStatusMessage = 
progress.getDeploymentStatus().getMessage();
+                        }
                    }
                } else {
                    fullStatusMessage = 
progress.getDeploymentStatus().getMessage();