[ https://issues.apache.org/jira/browse/GERONIMO-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634553#action_12634553 ]
David Jencks commented on GERONIMO-4323: ---------------------------------------- ejbs fixed in rev 699024. It's still possible to create a non-installable plugin by giving it a non-car type in the plan. > Plugin installation requires all plugins be of type "car", but default ejb > plugin is of type "jar" (and likely similar problems for other app types) > ---------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: GERONIMO-4323 > URL: https://issues.apache.org/jira/browse/GERONIMO-4323 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: deployment > Affects Versions: 2.2 > Reporter: David Jencks > Assignee: David Jencks > Fix For: 2.2 > > > AbstractRepository.copyToRepository bases the decision on whether to unpack > or copy an artifact on the type. Since all it gets is a stream and artifact, > I don't see any obvious ways to change this behavior: to actually detect if > something is a plugin you'd have to look at the content, which isn't > available when the decision is made. > I can see several ways out: > 1. make all plugins be of type car > 2. make packed plugins work (would require a new classloader and might cause > difficulties with tomcat and openejb integration) > 3. copy the file packed, peek inside, and unpack if necessary. > Unless there's strong opposition I'm going to try to implement (1). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.