[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712898#action_12712898
 ] 

Jürgen Weber commented on GERONIMODEVTOOLS-565:
-----------------------------------------------

I wonder, why GEP should need know the server runtime version. Geronimo server 
itself can cope with older deployment plans, too, isn't it? I think it looks at 
the given schema id and loads the right schema. So, couldn't GEP do the same?

And, even if that is not the case, opening a too-old-for-GEP deployment plan 
should result in a validation error and not NPE. Then the user herself could 
chose to manually open the plan in XML editor.

> NullPointerException on opening openejb-jar.xml
> -----------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-565
>                 URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-565
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.4
>            Reporter: Jürgen Weber
>            Assignee: Tim McConnell
>         Attachments: openejb-jar.xml
>
>
> Made new installation of eclipse-jee-ganymede-SR2-win32.zip by unzipping.
> Unzipped geronimo-eclipse-plugin-2.1.4-deployable.zip
> On opening the attached openejb-jar.xml with Geronimo editor I get the 
> exception below. It opens fine with XML editor.
> java.lang.NullPointerException
>       at 
> org.apache.geronimo.st.ui.editors.SharedDeploymentPlanEditor.getLoader(SharedDeploymentPlanEditor.java:120)
>       at 
> org.apache.geronimo.st.ui.editors.SharedDeploymentPlanEditor.loadDeploymentPlan(SharedDeploymentPlanEditor.java:100)
>       at 
> org.apache.geronimo.st.ui.editors.AbstractGeronimoDeploymentPlanEditor.init(AbstractGeronimoDeploymentPlanEditor.java:187)
>       at 
> org.eclipse.ui.internal.EditorManager.createSite(EditorManager.java:799)
>       at 
> org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:643)
>       at 
> org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:428)
>       at 
> org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:594)
>       at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:306)
>       at 
> org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:180)
>       at 
> org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:270)
>       at 
> org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65)
>       at 
> org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:473)
>       at 
> org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1256)
>       at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1209)
>       at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1608)
>       at org.eclipse.ui.internal.PartStack.add(PartStack.java:499)
>       at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:103)
>       at org.eclipse.ui.internal.PartStack.add(PartStack.java:485)
>       at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:112)
>       at 
> org.eclipse.ui.internal.EditorSashContainer.addEditor(EditorSashContainer.java:63)
>       at 
> org.eclipse.ui.internal.EditorAreaHelper.addToLayout(EditorAreaHelper.java:217)
>       at 
> org.eclipse.ui.internal.EditorAreaHelper.addEditor(EditorAreaHelper.java:207)
>       at 
> org.eclipse.ui.internal.EditorManager.createEditorTab(EditorManager.java:779)
>       at 
> org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:678)
>       at 
> org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:639)
>       at 
> org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2817)
>       at 
> org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2729)
>       at 
> org.eclipse.ui.internal.WorkbenchPage.access$11(WorkbenchPage.java:2721)
>       at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2673)
>       at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
>       at 
> org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2668)
>       at 
> org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2652)
>       at org.eclipse.ui.actions.OpenWithMenu.openEditor(OpenWithMenu.java:337)
>       at org.eclipse.ui.actions.OpenWithMenu.access$0(OpenWithMenu.java:325)
>       at 
> org.eclipse.ui.actions.OpenWithMenu$2.handleEvent(OpenWithMenu.java:187)
>       at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
>       at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
>       at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823)
>       at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422)
>       at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2384)
>       at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2348)
>       at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2200)
>       at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:495)
>       at 
> org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
>       at 
> org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:490)
>       at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
>       at 
> org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
>       at 
> org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
>       at 
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
>       at 
> org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
>       at 
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:386)
>       at 
> org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>       at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>       at java.lang.reflect.Method.invoke(Unknown Source)
>       at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549)
>       at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504)
>       at org.eclipse.equinox.launcher.Main.run(Main.java:1236)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to