Hi Donald; I have created a new jira issue and attached patches related with geronimo_jcdi and geronimo_atinject. Those patches satisfie David Jencks concerns. https://issues.apache.org/jira/browse/GERONIMO-5121
Thanks; --Gurkan ________________________________ From: Donald Woods <dwo...@apache.org> To: dev@geronimo.apache.org; d...@openwebbeans.apache.org Sent: Thu, February 4, 2010 3:31:59 PM Subject: Re: milestone release of geronimo-jcdi_1.0_spec ? Gurkan, if there are issues with the 1.0-beta code I just put up for a vote last night, then please open a new JIRA with the required patch and reply to that thread with the JIRA info. David, thus you can see why I am releasing all of these snapshot specs as 1.0-beta, since we have not run the full Java EE 6 TCK against them.... -Donald On 2/4/10 2:41 AM, David Jencks wrote: > > On Feb 3, 2010, at 10:49 PM, Gurkan Erdogdu wrote: > >> Hi David; >> >> I have found some wrong ordering and wrong serialize id. I will >> correct those in the afternoon and patch it. Donald has already >> started a vote. Does this problem blocks the beta- release ? > > I'll certainly vote -1 on a non-snapshot with known problems, and I hope > everyone else will too. I'm not that happy releasing specs until the > implementaition (e.g. openWebBeans) passes its tck, since we have found > subtle implementation problems in specs in the past. > > Many thanks for taking a look for these problems, better to look and fix > now than on day 3 of the vote :-) > > thanks > david jencks > >> >> Thanks; >> >> --Gurkan >> >> 2010/2/4 David Jencks <david_jen...@yahoo.com >> <mailto:david_jen...@yahoo.com>> >> >> Gurkan, >> >> We've recently found a couple more gotchas to check beyond the >> tck.... could you check these by hand? Having them wrong >> obviously impedes interoperability :-) >> >> 1. all serializable classes have the serialVersionUID as specified >> in the javadoc >> 2. any enums are specified in the order in the javadoc "Enum >> constant detail" and NOT that in "Enum constant summary" >> >> thanks >> david jencks >> >> >> On Feb 3, 2010, at 9:09 AM, Gurkan Erdogdu wrote: >> >>> That seems OK, It passed signature test. >>> >>> --Gurkan >>> >>> ------------------------------------------------------------------------ >>> *From:* Donald Woods <dwo...@apache.org <mailto:dwo...@apache.org>> >>> *To:* dev@geronimo.apache.org <mailto:dev@geronimo.apache.org> >>> *Cc:* Gurkan Erdogdu <gurkanerdo...@yahoo.com >>> <mailto:gurkanerdo...@yahoo.com>>; d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org> >>> *Sent:* Wed, February 3, 2010 5:13:11 AM >>> *Subject:* Re: milestone release of geronimo-jcdi_1.0_spec ? >>> >>> OK, the patch has been applied and new snapshots published. >>> Can you (or Blevins) run the signature tests against the latest >>> snapshots (jcdi, atinject and interceptor) and if everything passes >>> (please post the confirmation to our TCK list at >>> geronimo-...@geronimo.apache.org >>> <mailto:geronimo-...@geronimo.apache.org>) I'll create release >>> candidates for >>> them tomorrow? >>> >>> Also, can you verify that the following are the correct >>> dependencies, as >>> we have a geronimo-el_2.2_spec for Java EE 6 - >>> >>> <dependency> >>> <groupId>org.apache.geronimo.specs</groupId> >>> <artifactId>geronimo-interceptor_1.1_spec</artifactId> >>> <version>1.0.0-SNAPSHOT</version> >>> <scope>provided</scope> >>> </dependency> >>> <dependency> >>> <groupId>org.apache.geronimo.specs</groupId> >>> <artifactId>geronimo-el_1.0_spec</artifactId> >>> <version>1.0.2-SNAPSHOT</version> >>> <scope>provided</scope> >>> </dependency> >>> <dependency> >>> <groupId>org.apache.geronimo.specs</groupId> >>> <artifactId>geronimo-atinject_1.0_spec</artifactId> >>> <version>1.0-SNAPSHOT</version> >>> <scope>provided</scope> >>> </dependency> >>> >>> >>> -Donald >>> >>> On 2/2/10 2:11 PM, Gurkan Erdogdu wrote: >>> > Hi Donald; >>> > >>> > Thanks for the response. I have attached patch to >>> > https://issues.apache.org/jira/browse/GERONIMO-5101. >>> > >>> > We have a plan to release OpenWebBeans this week as soon as possible >>> > that you release geronimo-jcdi_1.0_spec and its dependents specs. >>> > >>> > Thanks >>> > >>> > --Gurkan >>> > >>> > >>> ------------------------------------------------------------------------ >>> > *From:* Donald Woods <dwo...@apache.org <mailto:dwo...@apache.org>> >>> > *To:* dev@geronimo.apache.org <mailto:dev@geronimo.apache.org> >>> > *Cc:* Gurkan Erdogdu <gurkanerdo...@yahoo.com >>> <mailto:gurkanerdo...@yahoo.com>>; d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org> >>> > *Sent:* Tue, February 2, 2010 3:56:38 PM >>> > *Subject:* Re: milestone release of geronimo-jcdi_1.0_spec ? >>> > >>> > For the geronimo spec api, if you open a JIRA and attach the >>> patch, one >>> > of us will get it committed and built for you. Once you verify >>> that the >>> > new jar passes the signature tests, we'll start a release vote.... >>> > >>> > >>> > -Donald >>> > >>> > >>> > On 2/1/10 4:35 PM, Gurkan Erdogdu wrote: >>> >> Moreover, I have to update API to pass CDI TCK signature tests. >>> >> Currently it fails. Is it possible to give me a commit access >>> to jcdi >>> >> and atinject projects? >>> >> >>> >> --Gurkan >>> >> >>> >> >>> ------------------------------------------------------------------------ >>> >> *From:* Gurkan Erdogdu <gurkanerdo...@yahoo.com >>> <mailto:gurkanerdo...@yahoo.com> >>> > <mailto:gurkanerdo...@yahoo.com <mailto:gurkanerdo...@yahoo.com>>> >>> >> *To:* d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org> >>> > <mailto:d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org>>; dev@geronimo.apache.org >>> <mailto:dev@geronimo.apache.org> >>> > <mailto:dev@geronimo.apache.org <mailto:dev@geronimo.apache.org>> >>> >> *Cc:* d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org> >>> <mailto:d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org>> >>> >> *Sent:* Mon, February 1, 2010 11:05:10 PM >>> >> *Subject:* Re: milestone release of geronimo-jcdi_1.0_spec ? >>> >> >>> >> Hello,.addInterceptorBinding(java.lang.Class<? extends >>> >> java.lang.annotation.Annotation>) >>> >> >>> >> This is also required for geronimo-interceptor_1.1_spec, >>> currently we >>> >> use 1.0.0-EA1-SNAPSHOT >>> >> >>> >> >>> >> --Gurkan >>> >> >>> >> >>> >> >>> >> ________________________________ >>> >> From: Mark Struberg <strub...@yahoo.de >>> <mailto:strub...@yahoo.de> <mailto:strub...@yahoo.de >>> <mailto:strub...@yahoo.de>> >>> > <mailto:strub...@yahoo.de >>> <mailto:strub...@yahoo.de> <mailto:strub...@yahoo.de >>> <mailto:strub...@yahoo.de>>>> >>> >> To: dev@geronimo.apache.org >>> <mailto:dev@geronimo.apache.org> <mailto:dev@geronimo.apache.org >>> <mailto:dev@geronimo.apache.org>> >>> > <mailto:dev@geronimo.apache.org >>> <mailto:dev@geronimo.apache.org> <mailto:dev@geronimo.apache.org >>> <mailto:dev@geronimo.apache.org>>> >>> >> Cc: d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org> >>> <mailto:d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org>> >>> > <mailto:d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org> >>> <mailto:d...@openwebbeans.apache.org >>> <mailto:d...@openwebbeans.apache.org>>> >>> >> Sent: Mon, February 1, 2010 10:54:16 PM >>> >> Subject: milestone release of geronimo-jcdi_1.0_spec ? >>> >> >>> >> Hi folks! >>> >> >>> >> We (most probably poor Gurkan ;) ) will do a release of >>> OpenWebBeans >>> >> Milestone 4 in the next days and need our API to be release also. >>> >> >>> >> Can anyone please be so kind and do the release of a milestone >>> of the >>> >> jcdi-spec-1.0 for us? >>> >> >>> >> txs in advance and LieGrue, >>> >> strub >>> >> >>> >> >>> >> >>> ___________________________________________________________________ >>> >> Yahoo! Türkiye açıldı! http://yahoo.com.tr >>> >> İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor! >>> >> >>> >> >>> ------------------------------------------------------------------------ >>> >> Yahoo! Türkiye açıldı! >>> >> Haber, Ekonomi, Videolar, Oyunlar hepsi Yahoo! Türkiye'de! >>> >> www.yahoo.com.tr >>> <http://www.yahoo.com.tr> <http://www.yahoo.com.tr> >>> <http://tr.yahoo.com/> >>> > >>> > >>> ------------------------------------------------------------------------ >>> > Yahoo! Türkiye açıldı! >>> > Haber, Ekonomi, Videolar, Oyunlar hepsi Yahoo! Türkiye'de! >>> > www.yahoo.com.tr <http://www.yahoo.com.tr> <http://tr.yahoo.com/> >>> >>> ------------------------------------------------------------------------ >>> Yahoo! Türkiye açıldı! >>> Haber, Ekonomi, Videolar, Oyunlar hepsi Yahoo! Türkiye'de! >>> www.yahoo.com.tr <http://tr.yahoo.com/> >> >> >> >> >> -- >> Gurkan Erdogdu >> http://gurkanerdogdu.blogspot.com > ___________________________________________________________________ Yahoo! Türkiye açıldı! http://yahoo.com.tr İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!