[ 
https://issues.apache.org/jira/browse/GERONIMO-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shenghao Fang updated GERONIMO-5748:
------------------------------------

    Description: 
2 defects found in ThreadSingletonServiceAdapter:

1. ClassCastException on  ThreadSingletonServiceAdapter: 69

{code:borderStyle=solid}
// The type of old is WebBeansContext, we need to create a new OWBContext 
wrapper instance.
startupObject.getAppContext().set(OWBContext.class, (OWBContext) old);
{code}

2. Incorrect judgement on ThreadSingletonServiceAdapter: 96

{code:borderStyle=solid}
// The type of oldContext is expected to be WebBeansContext instead of Map.
95    public void contextExited(Object oldContext) {
96        if (oldContext != null && !(oldContext instanceof Map)) throw new 
IllegalArgumentException("Expecting a Map<String, Object> not " + 
oldContext.getClass().getName());
97        GeronimoSingletonService.contextExited((WebBeansContext) oldContext);
98    }
{code}




  was:
2 defects found in ThreadSingletonServiceAdapter:

1. ClassCastException on  ThreadSingletonServiceAdapter: 69

startupObject.getAppContext().set(OWBContext.class, (OWBContext) old);

Here the type of old is WebBeansContext, we need to create a new OWBContext 
wrapper instance.

2. Incorrect judgement on ThreadSingletonServiceAdapter: 96
95    public void contextExited(Object oldContext) {
96        if (oldContext != null && !(oldContext instanceof Map)) throw new 
IllegalArgumentException("Expecting a Map<String, Object> not " + 
oldContext.getClass().getName());
97        GeronimoSingletonService.contextExited((WebBeansContext) oldContext);
98    }

Here the type of oldContext is expected to be WebBeansContext instead of Map.



> Defects in ThreadSingletonServiceAdapter
> ----------------------------------------
>
>                 Key: GERONIMO-5748
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5748
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: OpenEJB
>         Environment: Java(TM) SE Runtime Environment (build 1.6.0_22-b04)
>            Reporter: Shenghao Fang
>            Assignee: Shenghao Fang
>         Attachments: GERONIMO-5748.patch
>
>
> 2 defects found in ThreadSingletonServiceAdapter:
> 1. ClassCastException on  ThreadSingletonServiceAdapter: 69
> {code:borderStyle=solid}
> // The type of old is WebBeansContext, we need to create a new OWBContext 
> wrapper instance.
> startupObject.getAppContext().set(OWBContext.class, (OWBContext) old);
> {code}
> 2. Incorrect judgement on ThreadSingletonServiceAdapter: 96
> {code:borderStyle=solid}
> // The type of oldContext is expected to be WebBeansContext instead of Map.
> 95    public void contextExited(Object oldContext) {
> 96        if (oldContext != null && !(oldContext instanceof Map)) throw new 
> IllegalArgumentException("Expecting a Map<String, Object> not " + 
> oldContext.getClass().getName());
> 97        GeronimoSingletonService.contextExited((WebBeansContext) 
> oldContext);
> 98    }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to