[
https://issues.apache.org/jira/browse/GERONIMO-5765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995339#comment-12995339
]
Jarek Gawor commented on GERONIMO-5765:
---------------------------------------
I believe you are right about GEP calling Deployer. But there is no need to
open the jar file on each deploy and read its manifest. We only need to do that
for web applications. Unless we want to make this very generic and check every
module for basic OSGi manifest and warn that for example "Deploying module as a
regular Java EE application. Its existing OSGi manifest will be ignored".
I'm ok with the generic approach just make sure to close the JarFile :) and
check for Bundle-SymbolicName header only. Also, the change to
DeploymentPortlet is unnecessary - just checking the extension is insufficient.
> Display a warning message when web application is deployed with WAB manifest
> ----------------------------------------------------------------------------
>
> Key: GERONIMO-5765
> URL: https://issues.apache.org/jira/browse/GERONIMO-5765
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: deployment
> Affects Versions: 3.0-M2, 3.0
> Reporter: viola.lu
> Assignee: Rex Wang
> Fix For: 3.0-M2, 3.0
>
>
> Now WAB has to be deployed via karaf shell like a regular bundle, so if you
> deploy it via admin console, deployer will just recognize it as java ee web
> application, not osgi WAB.
> So display a warning message to inform users.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
