I've reviewed the code, it's better and more concise than I did[?], thank you very much, Jarek.
When I test the new feature, I find a problem that when restart the eclipse and modify the bundle's symbolic name or version, then publish the bundle to the server, the server would not remove the previous one! The root cause is when the eclipse restarts, the bundle Map's info is empty, so it could not get the cached bundle id and also the bundle's symbolic name or version has been changed, so it could not find the bundle id from server side by them, the bundle will be an isolated and never used one in server side. Maybe we still need persist the bundle map in GEP side, but just persist the bundle module id, symbolic name,version and the module's state(is removed or something else), the module state can be obtained by a resource changed listener as I patched before. What's your option? On Tue, Jul 12, 2011 at 1:45 AM, Jarek Gawor (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063449#comment-13063449] > > Jarek Gawor commented on GERONIMODEVTOOLS-759: > ---------------------------------------------- > > In revision 1145251 I refactored the module handling code. I separated it > into two separate classes - one for handling the Java EE modules and EBAs > and second one for handling OSGi bundles. I also simplified the OSGi > handling code. > Please review in case I missed something. > > > > Using the new APIs to manage the bundles status both in GEP and Server > side > > > ---------------------------------------------------------------------------- > > > > Key: GERONIMODEVTOOLS-759 > > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-759 > > Project: Geronimo-Devtools > > Issue Type: Improvement > > Components: eclipse-plugin > > Affects Versions: 3.0 > > Environment: WinXP sp3 32bit& Win7 64bit, Oracle JDK 1.6, > Eclipse3.6SR1&SR2 > > Reporter: Yi Xiao > > Assignee: Jarek Gawor > > Labels: OSGI, bundle > > Fix For: 3.0 > > > > Attachments: OSGIBundleDeploy.patch, > OSGIBundleDeploy_changeAPI.patch, OSGIBundleDeploy_changeAPI2_759.patch, > OSGIBundleDeploy_changePOM_759.patch > > > > > > This improvement depends on the server's modules, so, if the server side > does not update timely, it may cause the GEP compile failure! > > -- > This message is automatically generated by JIRA. > For more information on JIRA, see: http://www.atlassian.com/software/jira > > > -- Best regards! John Xiao
<<330.gif>>
