[ 
https://issues.apache.org/jira/browse/GERONIMO-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240477#comment-13240477
 ] 

Russell E Glaue commented on GERONIMO-6287:
-------------------------------------------

I agree with the patch GERONIMO-5164/new-instance+30.patch

It creates/copies {{var}} and {{etc}}
And only creates {{repository}}

With changes provided in GERONIMO-6270, the {{repository}} directory gets 
created automatically on server startup if it does not exist.

I would remove the comment in the patch that reads:
{code}
+        //?? repository folder needed by karaf, but don't know why ?
{code}

Karaf requires a repository local to the base path of the geronimo server 
instance. Karaf specifically looks for it on startup, but does nothing with it.

We have the {{o.a.g.server.dir/repository}} configured in 
o.a.g.server.dir/etc/org.ops4j.pax.url.mvn.cfg as:
{code}
org.ops4j.pax.url.mvn.defaultRepositories=file:${karaf.home}/repository@snapshots,file:${karaf.base}/repository@snapshots
{code}
Karaf looks for artifacts to deploy from one repository if the server is a 
single server, or two repositories if the server is one of multiple instances. 
When running multiple instance {{karaf.home/repository}} is the read-only 
bootstrap repository, and {{karaf.base/repository}} is the read-write local 
deploy repository for the specific geronimo instance.

It is not safe for multiple instances to deploy to the same bootstrap 
repository, as one instance's deployment will be seen by another. So we need to 
separate out local repositories for each instance to deploy to.

If a comment is desired, I recommend this:
{code}
+        //the repository folder is needed for local deployments, defined in 
etc/org.ops4j.pax.url.mvn.cfg
+        //we want to deploy artifacts specific to the instance to this local 
repository, not the shared bootstrap repository
{code}

                
> Server instance which created by gogo command "deploy:new-server-instance 
> "can't be started 
> --------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-6287
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6287
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: commands, osgi
>    Affects Versions: 3.0-beta-1
>         Environment: JDK6 SR10
> Redhat 6.1 x86_64 GNU/Linux
> Build: 2012.02.23
>            Reporter: Tina Li
>            Assignee: xiezhi
>            Priority: Minor
>         Attachments: gogoCommand.patch
>
>
> Steps:
> 1. Start geronimo successfully using ./geronimo.sh run 
> 2. Using gogo command to create a new instance named inst1:
>  geronimo> deploy:new-server-instance  inst1
> Connection established
> Server created
> 3.Change the PortOffset of the new instance
> 4. Try to start the server instance:
> $ export GERONIMO_SERVER=inst1
> $ bin/geronimo.sh run -l
> 5. But failed to start:
> Error launching framework: java.lang.IllegalArgumentException: Property 
> karaf.framework must be set in the etc/config.properties configuration file
> 6.Check the content under <geronimo_home>/inst1, only /var existed but /etc 
> missing

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to