Minor issue -- the copyright date in the source NOTICE file is out-of-date Everything else -- build, src, etc looks good.
Here's my +1 --kevan On May 3, 2012, at 4:08 AM, Forrest Xia wrote: > This is a release with some major changes from 1.1.1 as following: > ------------------------------------------------------------------------ > r1333343 | xiaming | 2012-05-03 03:56:03 -0400 (Thu, 03 May 2012) | 1 line > > GERONIMO-6343 Update pom to include the private impl package and fix a code > error > ------------------------------------------------------------------------ > r1098801 | djencks | 2011-05-02 17:43:18 -0400 (Mon, 02 May 2011) | 1 line > > GERONIMO-5944 Remove use of sxc. Refactor into separate model and > implementation > ------------------------------------------------------------------------ > r1096035 | djencks | 2011-04-22 17:00:03 -0400 (Fri, 22 Apr 2011) | 1 line > > GERONIMO-5927 don't force use of our xml spec versions since plain jaxb/sxc > work fine > > > The artifacts up for vote are: > https://repository.apache.org/content/repositories/orgapachegeronimo-030/org/apache/geronimo/components/geronimo-jaspi/2.0.0/geronimo-jaspi-2.0.0-source-release.tar.gz > https://repository.apache.org/content/repositories/orgapachegeronimo-030/org/apache/geronimo/components/geronimo-jaspi/2.0.0/geronimo-jaspi-2.0.0-source-release.zip > > The tag is: > http://svn.apache.org/repos/asf/geronimo/components/jaspi/tags/geronimo-jaspi-2.0.0/ > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > -- > Thanks! > > Regards, Forrest >
