Vote pass with these +1 votes: Forrest Shawn John Rex Ivan Kevan
On Wed, Jul 11, 2012 at 8:26 PM, Kevan Miller <kevan.mil...@gmail.com>wrote: > > On Jul 10, 2012, at 9:44 PM, Forrest Xia wrote: > > > On Fri, Jul 6, 2012 at 8:30 PM, Kevan Miller <kevan.mil...@gmail.com> > wrote: > > -1 > > > > The source archive is MS-DOS formatted. This causes errors like: > > > > ./bin/dbscripts/derby/createDerbyDB.sh: /bin/bash^M: bad interpreter: No > such file or directory > > > > our use of native file encoding in this case, is not quite appropriate… > > > > After fixing the MS-DOS format of the shell script, I got this: > > > > $ > GERONIMO_HOME=/Users/kevan/tmp/release/server/geronimo-tomcat7-javaee6-3.0.0/ > ./createDerbyDB.sh > > > GERONIMO_HOME=/Users/kevan/tmp/release/server/geronimo-tomcat7-javaee6-3.0.0/ > ./createDerbyDB.sh > > Invoking IJ command line tool to create the database and tables...please > wait > > Exception in thread "main" java.lang.NoClassDefFoundError: > org/apache/derby/tools/ij > > Caused by: java.lang.ClassNotFoundException: org.apache.derby.tools.ij > > at java.net.URLClassLoader$1.run(URLClassLoader.java:202) > > at java.security.AccessController.doPrivileged(Native Method) > > at java.net.URLClassLoader.findClass(URLClassLoader.java:190) > > at java.lang.ClassLoader.loadClass(ClassLoader.java:306) > > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) > > at java.lang.ClassLoader.loadClass(ClassLoader.java:247) > > Table creation complete > > > > This is caused because DERBY_VER in the createDerbyDB.sh script is > incorrect. > > Kevan, with Tina's comment, do you still think this small issue will > stop this samples release? > > I was following the README instructions. If you can explain to me how > somebody would read our instructions and get daytrader to work, then I'd > change my vote… > > --kevan -- Thanks! Regards, Forrest
