Not 100% sure we should go xbean-5.x. Otoh I'm totally fine either ways. We might end up pushing the major version every half a year with the new Java cadence :(
Another thought: It might happen that we have both shaded asm6 and 7 for a short period in time in TomEE. But as soon as xbean-asm7 is done I'll run OpenJPA and OpenWebBeans releases with the new xbean-asm7. So this period should really only be very short. And possibly we even manage to get it down to nada. LieGrue, strub > Am 02.10.2018 um 00:34 schrieb David Blevins <[email protected]>: > >> On Oct 1, 2018, at 7:12 AM, Romain Manni-Bucau <[email protected]> wrote: >> >> :) as usual with asm, looks ok but breaks several apps ;). But main point >> is: do we want to export as asm6 the real asm7 and fake the runtime it will >> work? If we want a smooth upgrade we can update asm6 module to have some of >> changes but keep asm7 module to ensure we cover it IMHO. > > We should definitely not introduce ASM 7 code into our asm6 module. > > Another topic is we've been on ASM 6 for 2 years. Should we change the XBean > major version to 5 when we switch to ASM 7? > > That would give us the option to keep pushing out XBean 4.x releases with > further ASM 6 updates for those who can't/won't upgrade yet or also have > stable branches to maintain. > > If if we don't change the major version and any critical bugs or security > vulnerabilities hit XBean 4.10, we'd have to do a 4.10.1. If that happened a > few times we'd find ourselves with 4.10.2, 4.10.3 and effectively maintaining > a de facto branch, just after the fact and in a very awkward way. > > > -David >
