Hmm, we can add a check in the filter and fail the deployment but at the
end it is a bug in CDI support of TomEE so likely saner to fix it in TomEE,
right?

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 22 janv. 2019 à 15:37, Ivan Junckes Filho <ivanjunc...@gmail.com> a
écrit :

> I would say if the extension was not executed for some reason that we need
> to know why, we need to make sure the filter doesn't throw that exception
> or completely ignore the filter logic right?
>
> On Tue, Jan 22, 2019 at 12:08 PM Romain Manni-Bucau <rmannibu...@gmail.com>
> wrote:
>
>> Hi Ivan,
>>
>> This means the opentracing extension was not executed for the app:
>> https://github.com/apache/geronimo-opentracing/blob/master/geronimo-opentracing/src/main/java/org/apache/geronimo/microprofile/opentracing/microprofile/cdi/OpenTracingExtension.java#L125
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github
>> <https://github.com/rmannibucau> | LinkedIn
>> <https://www.linkedin.com/in/rmannibucau> | Book
>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>
>>
>> Le mar. 22 janv. 2019 à 14:39, Ivan Junckes Filho <ivanjunc...@gmail.com>
>> a écrit :
>>
>>> Hey guys, I would like some help with an opentracing issue. I am not
>>> sure if it was already fixed or not. It was happening on version 1.0.0,
>>> current M1 release of TomEE 8.
>>>
>>> There is a nullpointer happening in OpenTracingFilter and it seems to
>>> be because this injection is null.
>>>
>>> @Inject
>>> private GeronimoOpenTracingConfig config;
>>>
>>> So this line throws the null pointer:
>>>
>>> skipDefaultTags = 
>>> Boolean.parseBoolean(config.read("filter.forcedTracing.skipDefaultTags", 
>>> "false"));
>>>
>>> Anyone can help with this?
>>>
>>> Logs are attached.
>>>
>>>
>>>

Reply via email to